LTTng » LTTng-tools

(I'm not submitting a patch because I'm not set up to prepare one as of right now)

In lttng-tools src common error.c we have, at lines ~60 and ~75:

[ ERROR_INDEX(LTTNG_ERR_KERN_STOP_FAIL) ] = "Stoping kernel trace failed",
[...]
[ ERROR_INDEX(LTTNG_ERR_UST_STOP_FAIL) ] = "Stoping UST trace failed",

"Stoping" should be "Stopping".

At lines ~42, ~67, ~80-82 and ~99:

[ ERROR_INDEX(LTTNG_ERR_EXIST_SESS) ] = "Session name already exist",
[...]
[ ERROR_INDEX(LTTNG_ERR_UST_CHAN_EXIST) ] = "UST channel already exist",
[...]
[ ERROR_INDEX(LTTNG_ERR_UST_EVENT_EXIST) ] = "UST event already exist",
[ ERROR_INDEX(LTTNG_ERR_UST_EVENT_NOT_FOUND)] = "UST event not found",
[ ERROR_INDEX(LTTNG_ERR_UST_CONTEXT_EXIST)] = "UST context already exist",
[...]
[ ERROR_INDEX(LTTNG_ERR_FILTER_EXIST) ] = "Filter already exist",

"exist" should be "exists".

At line ~93:

[ ERROR_INDEX(LTTNG_ERR_URL_CTRL_MISS) ] = "Missing control data path URL",

The text should be just "Missing control path URL"

At line ~84:

[ ERROR_INDEX(LTTNG_ERR_NEED_ROOT_SESSIOND) ] = "Tracing the kernel requires a root lttng-sessiond daemon and \"tracing\" group user membership",

That's not true: 'tracing' group membership is useful, but it is not required: the user can always sudo his LTTng kernel tracing commands. Changing "and" into "or" would do the trick.