Project

General

Profile

Actions
Copy link

Bug #459

closed

babeltrace ignores -w, --output option

Added by Daniel U. Thibault over 11 years ago. Updated over 11 years ago.

Status:
Invalid
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
02/22/2013
Due date:
% Done:

0%

Estimated time:

Description

Currently, babeltrace ignores the -w, --output option.

This turns out to be caused by this snippet of babeltrace.c (lines ~110-113):

static struct poptOption long_options[] = {
    /* longName, shortName, argInfo, argPtr, value, descrip, argDesc */
    { "output", 'w', POPT_ARG_STRING, NULL, OPT_NONE, NULL, NULL },
    { "input-format", 'i', POPT_ARG_STRING, NULL, OPT_INPUT_FORMAT, NULL, NULL },

which should instead be:

static struct poptOption long_options[] = {
    /* longName, shortName, argInfo, argPtr, value, descrip, argDesc */
    { "output", 'w', POPT_ARG_STRING, NULL, OPT_OUTPUT_PATH, NULL, NULL },
    { "input-format", 'i', POPT_ARG_STRING, NULL, OPT_INPUT_FORMAT, NULL, NULL },
Actions
Copy link
 #1

Updated by Mathieu Desnoyers over 11 years ago

  • Status changed from New to Invalid

Already fixed by commit:

commit c790c052a84aa223002e6a9be2583861bb27a40a
Author: Sebastian Andrzej Siewior <>
Date: Thu Feb 14 10:38:16 2013 -0500

Fix: babeltrace: make '-w' actually work
Signed-off-by: Sebastian Andrzej Siewior &lt;&gt;
    Signed-off-by: Mathieu Desnoyers &lt;&gt;

diff --git a/converter/babeltrace.c b/converter/babeltrace.c
index fe7d39f..31e3d6e 100644
--- a/converter/babeltrace.c
++ b/converter/babeltrace.c
@ -109,7 +109,7 @ enum {
/
static struct poptOption long_options[] = {
/ longName, shortName, argInfo, argPtr, value, descrip, argDesc */
- { "output", 'w', POPT_ARG_STRING, NULL, OPT_NONE, NULL, NULL },
 { "output", 'w', POPT_ARG_STRING, NULL, OPT_OUTPUT_PATH, NULL, NULL }, { "input-format", 'i', POPT_ARG_STRING, NULL, OPT_INPUT_FORMAT, NULL, NULL }, { "output-format", 'o', POPT_ARG_STRING, NULL, OPT_OUTPUT_FORMAT, NULL, NULL }, { "help", 'h', POPT_ARG_NONE, NULL, OPT_HELP, NULL, NULL },

Please update your tree, and make sure you follow the master branch.

Actions
Copy link

Also available in: Atom PDF