Project

General

Profile

Actions
Copy link

Bug #838

closed

Compilation error on Ubuntu kernel 3.16+

Added by Anonymous about 10 years ago. Updated about 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
09/15/2014
Due date:
% Done:

0%

Estimated time:

Description

Compiling lttng-modules on Ubuntu 14.10 with today's updates (which is using a 3.16.x kernel), I get the following errors with both the stable-2.5 and master branches (and also with the lttng-modules-2.5.0 tarball for that matter):

  CC [M]  /home/alexandre/src/lttng/lttng-modules/lttng-modules/lttng-ring-buffer-metadata-mmap-client.o
  CC [M]  /home/alexandre/src/lttng/lttng-modules/lttng-modules/lttng-statedump-impl.o
/home/alexandre/src/lttng/lttng-modules/lttng-modules/lttng-statedump-impl.c: In function ‘lttng_statedump_process_ns’:
/home/alexandre/src/lttng/lttng-modules/lttng-modules/lttng-statedump-impl.c:393:2: error: implicit declaration of function ‘task_nsproxy’ [-Werror=implicit-function-declaration]
  proxy = task_nsproxy(p);
  ^
/home/alexandre/src/lttng/lttng-modules/lttng-modules/lttng-statedump-impl.c:393:8: warning: assignment makes pointer from integer without a cast
  proxy = task_nsproxy(p);
        ^
cc1: some warnings being treated as errors

This seems different from bug #823, as I don't even get to that point.

Files

ns_proxy.diff (1.83 KB) ns_proxy.diff Julien Desfossez, 09/30/2014 06:00 PM
Actions
Copy link
 #1

Updated by Anonymous about 10 years ago

  • Subject changed from Compilation error on kernel 3.16 to Compilation error on kernel 3.16+

FWIW, the same error also happens with kernel 3.17-rc5.

Actions
Copy link
 #2

Updated by Anonymous about 10 years ago

  • Subject changed from Compilation error on kernel 3.16+ to Compilation error on Ubuntu kernel 3.16+

Alexandre Montplaisir wrote:

FWIW, the same error also happens with kernel 3.17-rc5.

Hmm, I may not have been testing with the very latest version, I just noticed commit http://git.lttng.org/?p=lttng-modules.git;a=commitdiff;h=4ba1f53c5aebb4433fedc25d65af010274985043 in master...

Although, building still failed on my Ubuntu 3.16 kernel. But! Turns out it's because Ubuntu backported that patch from 3.17 into their 3.16 kernel, see: http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-utopic.git;a=commit;h=d19cf09457ec80ee7b277281313faa07cd941379

If I change the values to "3.16" in that file manually, then it builds and installs fine. Ubuntu 14.10 will ship with 3.16 from the looks of it, so I guess this means a(nother) packaging patch!

Once I manage to get the PPA package working and installing, I'll close this bug, since this seems to be a distribution-specific issue.

Actions
Copy link
 #3

Updated by Anonymous about 10 years ago

  • Status changed from New to Invalid

Ok, the "2.6~pre" (aka master branch) package now compiles and installs fine on Ubuntu 14.10. And seems to work too.

There seems to be other issues trying to compile the modules against a mainline 3.17 kernel, but that's outside of the scope of this bug ;)

Actions
Copy link
 #4

Updated by Francois Doray about 10 years ago

I got this compilation error with:
Linux francoisdorsal 3.13.0-36-generic #63-Ubuntu SMP Wed Sep 3 21:30:07 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

lttng-module commit:
commit 74f7b56a78514d321aaf8b3fffae174999070f71
Author: Mathieu Desnoyers <>
Date: Mon Sep 29 13:29:12 2014 -0400

It works fine with 3.13.0-35-generic.

Actions
Copy link
 #5

Updated by Julien Desfossez about 10 years ago

I confirm that this bug appears on the ubuntu stable kernel (trusty).

The attached patch fixes this problem.

Actions
Copy link
 #6

Updated by Anonymous about 10 years ago

Hoho, lookee at this:
http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-trusty.git;a=commit;h=9ca1fb67d57f9f6992d12232ce329cce4148a981

That same patch was also backported to Trusty's 3.13, between -35 and -36. We could workaround it in packaging (by changing the 3.16 in the patch down to 3.13). But if Julien's patch gets into lttng-modules upstream, that would make it even easier ;)

Actions
Copy link
 #7

Updated by Mathieu Desnoyers about 10 years ago

  • Status changed from Invalid to Feedback

Can you confirm whether it's now OK with stable-2.5 and master lttng-modules with these kernels ?

Actions
Copy link
 #8

Updated by Anonymous about 10 years ago

I just tried both master and stable-2.5, on both Ubuntu 14.04 (kernel 3.13) and 14.10 (kernel 3.16), and it all compiled fine!

I had marked it Invalid since it was a distribution-specific issue, but I'm glad to see it was fixed upstream despite it ;)

Actions
Copy link
 #9

Updated by Christian Babeux about 10 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom PDF