https://bugs.lttng.org/https://bugs.lttng.org/themes/lttng/favicon/a.ico?14249722912018-11-14T19:01:47ZLTTng bugs repositoryLTTng-UST - Bug #1171: lttng_ust_delete_fd_from_tracker: Assertion failurehttps://bugs.lttng.org/issues/1171?journal_id=33472018-11-14T19:01:47ZJonathan Rajotte Julienjonathan.rajotte-julien@efficios.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li><li><strong>Assignee</strong> set to <i>Jonathan Rajotte Julien</i></li></ul><p>Hi Stefan,</p>
<p>I'm looking into it. I was able to reproduce the problem.</p>
<p>In the mean time could you share with us your potential fix?</p>
<p>Thanks</p> LTTng-UST - Bug #1171: lttng_ust_delete_fd_from_tracker: Assertion failurehttps://bugs.lttng.org/issues/1171?journal_id=33482018-11-14T19:40:37ZJonathan Rajotte Julienjonathan.rajotte-julien@efficios.com
<ul></ul><p>Hi Stefan,</p>
<p>See <a class="external" href="https://lists.lttng.org/pipermail/lttng-dev/2018-November/028351.html">https://lists.lttng.org/pipermail/lttng-dev/2018-November/028351.html</a></p>
<p>Cheers</p> LTTng-UST - Bug #1171: lttng_ust_delete_fd_from_tracker: Assertion failurehttps://bugs.lttng.org/issues/1171?journal_id=33492018-11-14T19:41:16ZJonathan Rajotte Julienjonathan.rajotte-julien@efficios.com
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Feedback</i></li></ul> LTTng-UST - Bug #1171: lttng_ust_delete_fd_from_tracker: Assertion failurehttps://bugs.lttng.org/issues/1171?journal_id=33502018-11-14T20:03:07ZStefan Palade
<ul></ul><p>Jonathan Rajotte Julien wrote:</p>
<blockquote>
<p>Hi Stefan,</p>
<p>I'm looking into it. I was able to reproduce the problem.</p>
<p>In the mean time could you share with us your potential fix?</p>
<p>Thanks</p>
</blockquote>
<p>The fix on our side was the same as your proposal.</p>
<p>--- a/liblttng-ust/lttng-ust-elf.c<br />+<ins>+ b/liblttng-ust/lttng-ust-elf.c<br /><code>@ -249,7 +249,7 </code>@ struct lttng_ust_elf *lttng_ust_elf_create(const char *path)<br /> if (!elf) {<br /> goto error;<br /> }<br /><del><br /></ins> elf</del>>fd = -1;</p>
<pre><code>elf->path = strdup(path);<br /> if (!elf->path) {</code></pre> LTTng-UST - Bug #1171: lttng_ust_delete_fd_from_tracker: Assertion failurehttps://bugs.lttng.org/issues/1171?journal_id=33512018-11-14T20:04:31ZStefan Palade
<ul></ul><p>Stefan Palade wrote:</p>
<blockquote>
<p>Jonathan Rajotte Julien wrote:</p>
<blockquote>
<p>Hi Stefan,</p>
<p>I'm looking into it. I was able to reproduce the problem.</p>
<p>In the mean time could you share with us your potential fix?</p>
<p>Thanks</p>
</blockquote>
</blockquote>
<p>The fix on our side was the same as your proposal.</p>
<pre><code class="c syntaxhl" data-language="c"> <span class="o">---</span> <span class="n">a</span><span class="o">/</span><span class="n">liblttng</span><span class="o">-</span><span class="n">ust</span><span class="o">/</span><span class="n">lttng</span><span class="o">-</span><span class="n">ust</span><span class="o">-</span><span class="n">elf</span><span class="p">.</span><span class="n">c</span>
<span class="o">+++</span> <span class="n">b</span><span class="o">/</span><span class="n">liblttng</span><span class="o">-</span><span class="n">ust</span><span class="o">/</span><span class="n">lttng</span><span class="o">-</span><span class="n">ust</span><span class="o">-</span><span class="n">elf</span><span class="p">.</span><span class="n">c</span>
<span class="err">@@</span> <span class="o">-</span><span class="mi">249</span><span class="p">,</span><span class="mi">7</span> <span class="o">+</span><span class="mi">249</span><span class="p">,</span><span class="mi">7</span> <span class="err">@@</span> <span class="k">struct</span> <span class="n">lttng_ust_elf</span> <span class="o">*</span><span class="nf">lttng_ust_elf_create</span><span class="p">(</span><span class="k">const</span> <span class="kt">char</span> <span class="o">*</span><span class="n">path</span><span class="p">)</span>
<span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">elf</span><span class="p">)</span> <span class="p">{</span>
<span class="k">goto</span> <span class="n">error</span><span class="p">;</span>
<span class="p">}</span>
<span class="o">-</span>
<span class="o">+</span> <span class="n">elf</span><span class="o">-></span><span class="n">fd</span> <span class="o">=</span> <span class="o">-</span><span class="mi">1</span><span class="p">;</span>
<span class="n">elf</span><span class="o">-></span><span class="n">path</span> <span class="o">=</span> <span class="n">strdup</span><span class="p">(</span><span class="n">path</span><span class="p">);</span>
<span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">elf</span><span class="o">-></span><span class="n">path</span><span class="p">)</span> <span class="p">{</span>
</code></pre> LTTng-UST - Bug #1171: lttng_ust_delete_fd_from_tracker: Assertion failurehttps://bugs.lttng.org/issues/1171?journal_id=33752019-01-22T22:00:05ZJonathan Rajotte Julienjonathan.rajotte-julien@efficios.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="Fix: Initialize fd field of struct lttng_ust_elf to -1 at allocation In rare cases when the exec..." href="https://bugs.lttng.org/projects/lttng-ust/repository/lttng-ust/revisions/1ac2e79cfa9574fde7b3d09d4c6c2ec368185f7f">lttng-ust|1ac2e79cfa9574fde7b3d09d4c6c2ec368185f7f</a>.</p>