Project

General

Profile

Bug #1172

lttng-modules 2.10.6 does not compile under CentOS 7.6

Added by Charlie Brady 6 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Target version:
-
Start date:
12/05/2018
Due date:
% Done:

0%

Estimated time:

Description

...
CC [M] /home/speech/bradyc/rpms/BUILD/lttng-modules-2.10.6/obj/default/probes
/lttng-probe-timer.o
In file included from /home/speech/bradyc/rpms/BUILD/lttng-modules-2.10.6/obj/de
fault/probes/../probes/define_trace.h:100:0,
from /home/speech/bradyc/rpms/BUILD/lttng-modules-2.10.6/obj/de
fault/probes/../instrumentation/events/lttng-module/timer.h:354,
from /home/speech/bradyc/rpms/BUILD/lttng-modules-2.10.6/obj/de
fault/probes/lttng-probe-timer.c:43:
/home/speech/bradyc/rpms/BUILD/lttng-modules-2.10.6/obj/default/probes/../probes/lttng-tracepoint-event-impl.h:143:6: error: conflicting types for 'trace_timer_start'
void trace_##_name(proto);
^
/home/speech/bradyc/rpms/BUILD/lttng-modules-2.10.6/obj/default/probes/../probes/lttng-tracepoint-event-impl.h:55:2: note: in expansion of macro 'LTTNG_TRACEPOINT_EVENT_INSTANCE_MAP'
LTTNG_TRACEPOINT_EVENT_INSTANCE_MAP(map, name, map, PARAMS, PARAMS)
^
/home/speech/bradyc/rpms/BUILD/lttng-modules-2.10.6/obj/default/probes/../probes/lttng-tracepoint-event-impl.h:97:2: note: in expansion of macro 'LTTNG_TRACEPOINT_EVENT_MAP'
LTTNG_TRACEPOINT_EVENT_MAP(name, name, \
^
/home/speech/bradyc/rpms/BUILD/lttng-modules-2.10.6/obj/default/probes/../instrumentation/events/lttng-module/timer.h:75:1: note: in expansion of macro 'LTTNG_TRACEPOINT_EVENT'
LTTNG_TRACEPOINT_EVENT(timer_start,
^
In file included from include/linux/module.h:18:0,
from /home/speech/bradyc/rpms/BUILD/lttng-modules-2.10.6/obj/default/probes/lttng-probe-timer.c:23:
include/linux/tracepoint.h:176:21: note: previous definition of 'trace_timer_start' was here
static inline void trace
##name(proto) \
^
include/linux/tracepoint.h:283:3: note: in expansion of macro '__DECLARE_TRACE'
_DECLARE_TRACE(name, PARAMS, PARAMS, 1, \
^
include/linux/tracepoint.h:415:2: note: in expansion of macro 'DECLARE_TRACE'
DECLARE_TRACE(name, PARAMS, PARAMS)
^
include/trace/events/timer.h:44:1: note: in expansion of macro 'TRACE_EVENT'
TRACE_EVENT(timer_start,
^
make3: * [/home/speech/bradyc/rpms/BUILD/lttng-modules-2.10.6/obj/default/probes/lttng-probe-timer.o] Error 1
make2:
[/home/speech/bradyc/rpms/BUILD/lttng-modules-2.10.6/obj/default/probes] Error 2
make2:
Waiting for unfinished jobs....
make1:
[_module
/home/speech/bradyc/rpms/BUILD/lttng-modules-2.10.6/obj/default] Error 2
make1: Leaving directory `/usr/src/kernels/3.10.0-957.1.3.el7.x86_64'
make: *
* [modules] Error 2

History

#1

Updated by Charlie Brady 6 months ago

2.10.8 has the same issue.

#2

Updated by Michael Jeanson 6 months ago

  • Assignee set to Michael Jeanson
#4

Updated by Michael Jeanson 6 months ago

Hi,

I've submitted a patch to the mailing list : https://patchwork.lttng.org/patch/1870479/

It should be included in 2.10.9.

Regards,

Michael

#5

Updated by Charlie Brady 6 months ago

Thanks. That looks good.

#6

Updated by Michael Jeanson 6 months ago

  • Status changed from New to In Progress
#7

Updated by Mathieu Desnoyers 3 months ago

  • Status changed from In Progress to Resolved

Patch merged into master as:

commit 4eaeb54a27fbf701c2a4908a6e90a978b93deb06
Author: Michael Jeanson <mjeanson@efficios.com>
Date:   Thu Dec 6 11:31:51 2018 -0500

    Fix: timer instrumentation for RHEL 7.6

    Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
    Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

and backported to stable branches.

Also available in: Atom PDF