Project

General

Profile

Actions

Bug #718

closed

lttng-modules 2.4.0-rc2 doesn't compile with Linux kernel 3.13.0

Added by Marc-Andre Laperle about 10 years ago. Updated about 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
01/15/2014
Due date:
% Done:

0%

Estimated time:

Description

I am using Ubuntu 14.04 64 bit
http://lttng.org/files/lttng-modules/lttng-modules-2.4.0-rc2.tar.bz2
Linux 3.13.0-3-generic #18-Ubuntu SMP Mon Jan 13 19:11:13 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

CC [M]  /home/emalape/Documents/dev/sources/lttng-2.4-rc3/lttng-modules-2.4.0-rc2/probes/lttng-probe-kvm.o
In file included from /home/emalape/Documents/dev/sources/lttng-2.4-rc3/lttng-modules-2.4.0-rc2/probes/../instrumentation/events/lttng-module/../../../probes/define_trace.h:148:0,
from /home/emalape/Documents/dev/sources/lttng-2.4-rc3/lttng-modules-2.4.0-rc2/probes/../instrumentation/events/lttng-module/kvm.h:356,
from /home/emalape/Documents/dev/sources/lttng-2.4-rc3/lttng-modules-2.4.0-rc2/probes/lttng-probe-kvm.c:41:
/home/emalape/Documents/dev/sources/lttng-2.4-rc3/lttng-modules-2.4.0-rc2/probes/../instrumentation/events/lttng-module/../../../probes/lttng-events.h:151:6: error: conflicting types for ‘trace_kvm_async_pf_completed’
void trace_##_name(proto);
^
/home/emalape/Documents/dev/sources/lttng-2.4-rc3/lttng-modules-2.4.0-rc2/probes/../instrumentation/events/lttng-module/../../../probes/lttng-events.h:47:2: note: in expansion of macro ‘DEFINE_EVENT_MAP’
DEFINE_EVENT_MAP(map, name, map, PARAMS(proto), PARAMS(args))
^
/home/emalape/Documents/dev/sources/lttng-2.4-rc3/lttng-modules-2.4.0-rc2/probes/../instrumentation/events/lttng-module/../../../probes/lttng-events.h:89:2: note: in expansion of macro ‘TRACE_EVENT_MAP’
TRACE_EVENT_MAP(name, name, \
^
/home/emalape/Documents/dev/sources/lttng-2.4-rc3/lttng-modules-2.4.0-rc2/probes/../instrumentation/events/lttng-module/../../../probes/../instrumentation/events/lttng-module/kvm.h:328:1: note: in expansion of macro ‘TRACE_EVENT’
TRACE_EVENT(
^
In file included from include/linux/module.h:18:0,
from /home/emalape/Documents/dev/sources/lttng-2.4-rc3/lttng-modules-2.4.0-rc2/probes/lttng-probe-kvm.c:23:
include/linux/tracepoint.h:162:21: note: previous definition of ‘trace_kvm_async_pf_completed’ was here
static inline void trace
##name(proto) \
^
include/linux/tracepoint.h:259:3: note: in expansion of macro ‘__DECLARE_TRACE’
_DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), 1, \
^
include/linux/tracepoint.h:393:2: note: in expansion of macro ‘DECLARE_TRACE’
DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
^
include/trace/events/kvm.h:297:1: note: in expansion of macro ‘TRACE_EVENT’
TRACE_EVENT(
^
make[3]: * [/home/emalape/Documents/dev/sources/lttng-2.4-rc3/lttng-modules-2.4.0-rc2/probes/lttng-probe-kvm.o] Error 1
make[2]:
[/home/emalape/Documents/dev/sources/lttng-2.4-rc3/lttng-modules-2.4.0-rc2/probes] Error 2
make[1]:
[_module
/home/emalape/Documents/dev/sources/lttng-2.4-rc3/lttng-modules-2.4.0-rc2] Error 2
make[1]: Leaving directory `/usr/src/linux-headers-3.13.0-3-generic'
make: *
[default] Error 2

Files

instrumentation-events-lttng-module-kvm.h.patch (432 Bytes) instrumentation-events-lttng-module-kvm.h.patch Workaround patch Marc-Andre Laperle, 01/15/2014 05:45 PM
Actions #1

Updated by Marc-Andre Laperle about 10 years ago

I added a check for the kernel version in kvm.h. I'm not sure this is the right approach but at least I can compile it now.

Actions #2

Updated by Mathieu Desnoyers about 10 years ago

  • Status changed from New to Resolved

fixed by master commits (backported to stable-2.3):

commit 0d019e70c4c0acccbaed913487c4f0ce96aeda17
Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date:   Mon Jan 20 11:37:25 2014 -0500

    Update kvm instrumentation to Linux 3.13

    Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

commit 33673ee7b705adb6b24350c30966d4937d41ed95
Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date:   Mon Jan 20 11:31:30 2014 -0500

    Update sched instrumentation to Linux 3.13

    Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Actions

Also available in: Atom PDF