relayd mishandles channels configured with tracefile-count == 0 and tracefile-size != 0
Relayd mistakenly considers that the criterion tracefile-count == 0 means no tracefile rotation should happen for the stream.
However, it's possible that tracefile-size is set to non-zero, but tracefile-count is left at its default value of 0.
The expected behavior would be to have an ever increasing counter (no limit) of tracefiles each "size" in size at most.
I suspect the relayd receiving side may also be broken, because its rotation handling code also has the same incorrect assumptions.
When connecting a live client to such a session, we get on the client side:
[error] Remote side has closed connection
And a PERROR on relayd:
PERROR - 13:16:28.097800421 [8061/8068]: opening index in read-only: No such file or directory (in lttng_index_file_open() at index.c:261)
Likely caused by confusion between tracefile rotation suffixes in the filename.
No data to display