Project

General

Profile

Bug #1240

Can't write plugins solely with `--enable-python-plugins`

Added by Francis Deslauriers 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Category:
Build system
Start date:
02/21/2020
Due date:
% Done:

0%

Estimated time:

Description

If the user builds and install the project:

./configure --enable-python-plugins
make
make install

They won't be able to do the import bt2 necessary to start defining their BT2 plugin.
To write a Python plugin , the user needs to use the Python bindings as well.

The user gets this:

>>> import bt2
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'bt2'

We could either:
  1. turn on `--enable-python-bindings` whenever `--enable-python-plugins` is enabled,
  2. error out during the ./configure if `--enable-python-bindings` is not provided.
#1

Updated by Francis Deslauriers 3 months ago

  • Tracker changed from Feature to Bug
#2

Updated by Simon Marchi 3 months ago

I would suggest that using --enable-python-plugins automatically enables the python bindings, as long as --disable-python-bindings is not provided. In other words, this table:

plugins | bindings 
--------+---------
missing | missing  -> both disabled
missing | enable   -> plugins disabled, bindings enabled
missing | disable  -> both disabled
enable  | missing  -> both enabled
enable  | enable   -> both enabled
enable  | disable  -> error
disable | missing  -> both disabled
disable | enable   -> plugins disabled, bindings enabled
disable | disable  -> both disabled
#3

Updated by Francis Deslauriers 3 months ago

  • Assignee set to Francis Deslauriers
  • Status changed from New to In Progress
#4

Updated by Francis Deslauriers 3 months ago

  • Status changed from In Progress to Waiting for review
  • Category set to Build system
#5

Updated by Francis Deslauriers 3 months ago

Merge into master, should be merged in stable 2.0.

#6

Updated by Francis Deslauriers 3 months ago

  • Status changed from Waiting for review to Resolved

Also available in: Atom PDF