Project

General

Profile

Actions
Copy link

Bug #1249

closed

condition statement in wrapper/uaccess.h

Added by Xintian Wu about 4 years ago. Updated about 4 years ago.

Status:
Invalid
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
04/01/2020
Due date:
% Done:

0%

Estimated time:

Description

#if (LINUX_VERSION_CODE >= KERNEL_VERSION(5,0,0))
#define VERIFY_READ 0
#define VERIFY_WRITE 1
#define lttng_access_ok(type, addr, size) access_ok(addr, size)
#else /* LINUX_VERSION_CODE >= KERNEL_VERSION(5,0,0) /
#define lttng_access_ok(type, addr, size) access_ok(type, addr, size)
#endif / LINUX_VERSION_CODE >= KERNEL_VERSION(5,0,0) */

Should the first condition statement be "less than"?
On kernel 4.18, access_ok only takes two parameters but the second lttng_access_ok definition is invoked.

Actions
Copy link
 #1

Updated by Mathieu Desnoyers about 4 years ago

I double-checked, and vanilla v4.18 and v4.18.20 kernels access_ok() take 3 arguments, as expected by LTTng-modules.

Based on bug #1250 I suspect you are building against a CentOS 8.1 4.18 kernel. Am I correct ?

Note that RHEL and CentOS kernels integrate significant modifications from mainline kernels, and we need to track those distribution-specific changes very closely.

We need to identify the exact range of versions which include this change in the RHEL kernels so we can use the LTTNG_RHEL_KERNEL_RANGE() macro accordingly.

Actions
Copy link
 #2

Updated by Michael Jeanson about 4 years ago

  • Project changed from LTTng to LTTng-modules
Actions
Copy link
 #3

Updated by Xintian Wu about 4 years ago

Here is the system info:

cat /proc/version
Linux version 4.18.0-147.5.1.el8_1.x86_64 () (gcc version 8.3.1 20190507 (Red Hat 8.3.1-4) (GCC)) #1 SMP Wed Feb 5 02:00:39 UTC 2020

This is the latest CentOS 8.1 baseOS kernel.

Based on what you described, I think we can close this bug and maybe create a new combined bug for compilation under CentOS 8.1.

Actions
Copy link
 #4

Updated by Mathieu Desnoyers about 4 years ago

  • Status changed from New to Invalid
Actions
Copy link

Also available in: Atom PDF