Bug #1266
closed2.12 fails to compile with C++ code when using session clear feature
100%
Description
The below newly introduced header files:
- https://github.com/lttng/lttng-tools/blob/stable-2.12/include/lttng/clear.h
- https://github.com/lttng/lttng-tools/blob/stable-2.12/include/lttng/clear-handle.h
miss the closing:
#ifdef __cplusplus
}
#endif
section such that 2.12 fails to compile with C++ code when using session clear feature.
There might be some other headers also without the closing section that I didn't spot, please fix them altogether. Thanks!
Updated by Jonathan Rajotte Julien about 1 year ago
- Status changed from New to In Progress
Hi Shuo,
Thank for reporting the issue.
Is it okai with you if we add the Reported-by: tag with your information on the fix?
Other headers looks okai for stable 2.12, I'll also have a look at the master branch after.
Thanks again.
Updated by Shuo Yang about 1 year ago
Hi Jonathan,
Thanks for your quick response!
Of course. Feel to free add the necessary information on the fix.
Meanwhile, I noticed that https://github.com/lttng/lttng-tools/blob/stable-2.12/include/lttng/lttng.h doesn't contain clear.h and clear-handle.h.
Maybe you can also add them into it with the fix so that clients only need to include lttng.h?
Shuo
Updated by Jonathan Rajotte Julien about 1 year ago
Hi Shuo,
Not sure how this passed through our process. We will need to find a way to prevent that.
Thanks again!
Updated by Jonathan Rajotte Julien about 1 year ago
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Applied in changeset lttng-tools|316f62af004a770ebf808166d4c810d12d90b4e5.
Updated by Shuo Yang about 1 year ago
Hi Jonathan,
Thanks for the fix!
Will this fix be reflected in the latest ubuntu ppa (https://launchpad.net/~lttng/+archive/ubuntu/ppa/)?
Shuo
Updated by Jonathan Rajotte Julien about 1 year ago
Hi Shuo,
It will be as soon as we cut a patch level release for 2.12. I already talked with Jeremie on that end, we have a couple of fixes to get into 2.12 and we should be able to cut a release in the following weeks. Most probably end of next week if everything goes well.
Cheers
Updated by Jonathan Rajotte Julien 12 months ago
Hi Shuo,
Jeremie went ahead with the patch level release. It should propagate to the ppa un the upcoming days.
Cheers