Project

General

Profile

Bug #1266

2.12 fails to compile with C++ code when using session clear feature

Added by Shuo Yang 5 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Critical
Target version:
Start date:
05/11/2020
Due date:
% Done:

100%

Estimated time:
2.00 h

Description

The below newly introduced header files:

miss the closing:

#ifdef __cplusplus
}
#endif

section such that 2.12 fails to compile with C++ code when using session clear feature.

There might be some other headers also without the closing section that I didn't spot, please fix them altogether. Thanks!

#1

Updated by Jonathan Rajotte Julien 5 months ago

  • Status changed from New to In Progress

Hi Shuo,

Thank for reporting the issue.

Is it okai with you if we add the Reported-by: tag with your information on the fix?

Other headers looks okai for stable 2.12, I'll also have a look at the master branch after.

Thanks again.

#2

Updated by Shuo Yang 5 months ago

Hi Jonathan,

Thanks for your quick response!

Of course. Feel to free add the necessary information on the fix.

Meanwhile, I noticed that https://github.com/lttng/lttng-tools/blob/stable-2.12/include/lttng/lttng.h doesn't contain clear.h and clear-handle.h.
Maybe you can also add them into it with the fix so that clients only need to include lttng.h?

Shuo

#3

Updated by Jonathan Rajotte Julien 5 months ago

Hi Shuo,

Not sure how this passed through our process. We will need to find a way to prevent that.

Thanks again!

#4

Updated by Jonathan Rajotte Julien 5 months ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Resolved
#5

Updated by Shuo Yang 5 months ago

Hi Jonathan,

Thanks for the fix!

Will this fix be reflected in the latest ubuntu ppa (https://launchpad.net/~lttng/+archive/ubuntu/ppa/)?

Shuo

#6

Updated by Jonathan Rajotte Julien 5 months ago

Hi Shuo,

It will be as soon as we cut a patch level release for 2.12. I already talked with Jeremie on that end, we have a couple of fixes to get into 2.12 and we should be able to cut a release in the following weeks. Most probably end of next week if everything goes well.

Cheers

#7

Updated by Shuo Yang 5 months ago

Hi Jonathan,

Sounds good to me.

Thanks!
Shuo

#8

Updated by Jonathan Rajotte Julien 5 months ago

Hi Shuo,

Jeremie went ahead with the patch level release. It should propagate to the ppa un the upcoming days.

Cheers

#9

Updated by Shuo Yang 5 months ago

Great! Thank you all for the effort.

Also available in: Atom PDF