Project

General

Profile

Actions

Bug #1338

open

Crash when specifying convert command with custom python plug-in

Added by Jérémie Galarneau about 1 month ago. Updated about 1 month ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
CLI
Start date:
12/02/2021
Due date:
% Done:

0%

Estimated time:

Description

babeltrace2 convert -d --plugin-path=. input.aoc21

Results in a crash at

(gdb) bt
#0  0x00007fc325f61d22 in raise () from /usr/lib/libc.so.6
#1  0x00007fc325f4b862 in abort () from /usr/lib/libc.so.6
#2  0x000055882abffe3a in bt_common_abort () at common.c:2111
#3  0x000055882ac0d4ee in bt_config_convert_from_args (argc=argc@entry=3, 
    argv=argv@entry=0x7ffee7a2c538, cfg_out=cfg_out@entry=0x7ffee7a2c378, plugin_paths=0x55882cc26da0, 
    default_log_level=default_log_level@entry=0x7ffee7a2c2a4, 
    interrupter=interrupter@entry=0x55882cc26d60, consumed_args=1) at babeltrace2-cfg-cli-args.c:3606
#4  0x000055882ac123b0 in bt_config_cli_args_create (argc=argc@entry=5, argv=argv@entry=0x7ffee7a2c528, 
    cfg=cfg@entry=0x7ffee7a2c378, omit_system_plugin_path=omit_system_plugin_path@entry=false, 
    omit_home_plugin_path=<optimized out>, omit_home_plugin_path@entry=false, 
    initial_plugin_paths=initial_plugin_paths@entry=0x0, interrupter=0x55882cc26d60)
    at babeltrace2-cfg-cli-args.c:4951
#5  0x000055882ac140d2 in bt_config_cli_args_create_with_default (argc=argc@entry=5, 
    argv=argv@entry=0x7ffee7a2c528, cfg=cfg@entry=0x7ffee7a2c378, interrupter=<optimized out>)
    at babeltrace2-cfg-cli-args-default.c:70
#6  0x000055882abffef3 in main (argc=5, argv=0x7ffee7a2c528) at babeltrace2.c:2642

The current path (to which plugin-path points) contains a python plug-in.

import bt2

bt2.register_plugin(__name__, "aoc21")

class AOC21SourceValuesIterator(bt2._UserMessageIterator):
    def __init__(self, config, output_port):
        self._values_file = output_port.user_data[0]
        self._ping_ec = output_port.user_data[1]

        ping_sc = self._ping_ec.stream_class
        tc = ping_sc.trace_class

        trace = tc()
        self._value_stream = trace.create_stream(ping_sc)

        self._stream_begin_msg = self._create_stream_beginning_message(
            self._value_stream
        )
        self._stream_end_msg = self._create_stream_end_message(self._value_stream)

    def __next__(self):
        if self._stream_begin_msg:
            msg = self._stream_begin_msg
            self._stream_begin_msg = None
            return msg

        try:
            line = next(self._values_file)
        except StopIteration:
            if self._stream_end_msg:
                msg = self._stream_end_msg
                self._stream_end_msg
                return msg
            else:
                raise StopIteration

        event_msg = self._create_event_message(
            self._ping_ec, self._value_stream, default_clock_snapshot=0
        )

        event_msg.event.payload_field["depth"] = int(line)
        return event_msg

@bt2.plugin_component_class
class AOC21Source(
    bt2._UserSourceComponent, message_iterator_class=AOC21SourceValuesIterator
):
    def __init__(self, config, params, obj):
        if "path" not in params:
            raise ValueError("AOC21Source: missing `path` parameter")

        path = params["path"]

        if type(path) != bt2._StringValueConst:
            raise TypeError(
                "AOC21Source: expecting `path` parameter to be a string, got a {}".format(
                    type(path)
                )
            )

        values_file = open(str(path), "r")

        tc = self._create_trace_class()
        cc = self._create_clock_class()
        sc = tc.create_stream_class(default_clock_class=cc)

        ping_event_payload = tc.create_structure_field_class()
        ping_event_payload.append_member(
            "depth", tc.create_unsigned_integer_field_class()
        )

        ping_event_ec = sc.create_event_class(
            name="ping", payload_field_class=ping_event_payload
        )

        self._add_output_port("the-values", (values_file, ping_event_ec))

class WindowSum:
    def __init__(self, size: int):
        self._size = size
        self._values = []

    def add_value(self, value: int):
        if len(self._values) >= 3:
            raise RuntimeError
        self._values.append(value)

    @property
    def is_full(self) -> bool:
        return len(self._values) == 3

    @property
    def sum(self) -> int:
        return sum(self._values)

    def clear(self):
        self._values.clear()

@bt2.plugin_component_class
class AOC21Sink(bt2._UserSinkComponent):
    def __init__(self, config, params, obj):
        self._port = self._add_input_port("holiday-spirit")
        self._increase_count = 0
        self._last_completed_window_sum = None
        self._windows = []

    def _user_graph_is_configured(self):
        self._it = self._create_message_iterator(self._port)

    def _user_consume(self):
        msg = next(self._it)

        if type(msg) is bt2._EventMessageConst:
            depth = msg.event["depth"]

            # Initialize windows one after the other to maintain an offset
            # between them
            if len(self._windows) < 3:
                self._windows.append(WindowSum(3))

            for window in self._windows:
                window.add_value(depth)
                if window.is_full:
                    if (
                        self._last_completed_window_sum
                        and window.sum > self._last_completed_window_sum
                    ):
                        self._increase_count = self._increase_count + 1

                    self._last_completed_window_sum = window.sum
                    window.clear()

        elif type(msg) is bt2._StreamEndMessageConst:
            print(self._increase_count)
            raise bt2.Stop

Actions #1

Updated by Jérémie Galarneau about 1 month ago

  • Description updated (diff)
Actions

Also available in: Atom PDF