Project

General

Profile

Actions

Bug #1342

open

Rotation thread's handling of session consumed size notifications is racy

Added by Jérémie Galarneau 5 months ago.

Status:
New
Priority:
Low
Target version:
-
Start date:
12/09/2021
Due date:
% Done:

0%

Estimated time:

Description

Related to this change:
https://review.lttng.org/c/lttng-tools/+/6886/

The race described in that change has another consequence: the notification could refer to a different session instance of the same name:
  • notification emitted for session foo,
  • session foo is destroyed,
  • a new session named foo is created,
  • a rotation is triggered for foo.
There are multiple solutions for this:
  • Provide a unique session id as part the of the evaluation of SESSION_CONSUMED_SIZE,
  • Register an internal trigger that has the rotate session action (since ids are sampled during their handling).

I can't work on a fix right now, but here is a placeholder patch that will eventually contain the fix:
https://review.lttng.org/c/lttng-tools/+/6907

This is hypothetical and I noticed it during a code review; nobody reported this problem.

No data to display

Actions

Also available in: Atom PDF