Project

General

Profile

Bug #267

library should not do exit() for error handling

Added by Yannick Brosseau over 8 years ago. Updated almost 8 years ago.

Status:
Won't fix
Priority:
Low
Target version:
-
Start date:
03/05/2012
Due date:
% Done:

0%

Estimated time:

Description

It's impolite for a library to call exit().

We should find a better way to do error handling in those case

(
See output of rpmlist ran on fedora:
lttng-ust.x86_64: W: shared-lib-calls-exit /usr/lib64/liblttng-ust-ctl.so.0.0.0 exit@GLIBC_2.2.5

)


Related issues

Related to Userspace RCU - Bug #152: library should not do exit() for error handlingResolvedMathieu Desnoyers03/05/2012

Actions
#1

Updated by Yannick Brosseau over 8 years ago

  • Project changed from Userspace RCU to LTTng-UST
#2

Updated by Yannick Brosseau over 8 years ago

  • Description updated (diff)
#3

Updated by Mathieu Desnoyers about 8 years ago

  • Status changed from New to Feedback

please provide the call sites.

#4

Updated by Mathieu Desnoyers almost 8 years ago

  • Status changed from Feedback to Won't fix

Actually, the few _exit() called from liblttng-ust/lttng-ust-comm.c are called from a temporary child process forked from the library to open the shm wait file with the appropriate umask (and we don't want to change the application umask, so we do it in a child process).

Therefore, these _exit() calls are there to stay.

Thanks,

Mathieu

Also available in: Atom PDF