LTTng » LTTng-UST

I have determined that it's when the .tp file is "ust.tp" makes it easier
to check. :)

On Tue, Jul 3, 2012 at 3:52 PM, <bugs@lttng.org> wrote:

Issue #292 has been updated by Yannick Brosseau.

Status changed from New to Needs feedback

I cannot reproduce the problem, can you confirm it's not a problem with
your setup?
The exact version of LTTng-UST and gcc would be useful.
----------------------------------------
Bug #292: Lttng-gen-tp need additional error messages
https://bugs.lttng.org/issues/292#change-589

Author: Matthew Khouzam
Status: Needs feedback
Priority: Normal
Assignee: Yannick Brosseau
Category:
Target version:

In Lttng-UST 2.0 if a given tracepoint file (foo.tp) has tracepint_events
with domains that are not "foo" the tracepoint will not compile. This would
be good to have a warning/error for, since if you don't it will just cause
errors in the compilation phase which are very difficult to understand.

--
You have received this notification because you have either subscribed to
it, or are involved in it.
To change your notification preferences, please click here:
http://bugs.lttng.org/my/account

--
Matthew Khouzam, M.Ing
Embedded Systems Designer

Oh, interesting. I see the problem...

Hi Yannick,

This bug has been opened in July 2012. Any ETA for resolution ?

Thanks,

Mathieu

• bugs@lttng.org (bugs@lttng.org) wrote:

Issue #292 has been updated by Yannick Brosseau.

Subject changed from Lttng-gen-tp need additional error messages to Generated header files should not conflict with ust or standard ones.
Status changed from Needs feedback to Confirmed

----------------------------------------
Bug #292: Generated header files should not conflict with ust or standard ones.
https://bugs.lttng.org/issues/292#change-592

Author: Matthew Khouzam
Status: Confirmed
Priority: Normal
Assignee: Yannick Brosseau
Category:
Target version:

In Lttng-UST 2.0 if a given tracepoint file (foo.tp) has tracepint_events with domains that are not "foo" the tracepoint will not compile. This would be good to have a warning/error for, since if you don't it will just cause errors in the compilation phase which are very difficult to understand.

--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.lttng.org/my/account

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

Mathieu Desnoyers wrote:

Hi Yannick,

This bug has been opened in July 2012. Any ETA for resolution ?

Trying to find the best solution for this problem.
We could:
- Fail properly and tell the user to choose another file name
- Add a prefix to the generated file name
- Other solutions?

If I understand correctly, gen tp should enforce that if a tracepoint provider source file is called

"blah.tp"

then all the tracepoint events it contains should be in the "blah" provider. Am I missing something ?

If this is all that's needed, just printing an error message and exiting from gen tp would seem to be the right approach.

Thanks,

Mathieu

No, that's not the issue here (the original description is missleading).

You can generate tracepoing which have a provider of a name different that the .tp file without any problem.

The problem occurs when you have a tp file call the same of other header.
(I'm still figuring out the exact pattern for the problem)

Some more information:

When using -I. to compile, any file present named as one of the file included by ust-tracepoint-event.h

IE one of these:
#include <stdio.h>
#include <stdlib.h>
#include <urcu/compiler.h>
#include <urcu/rculist.h>
#include <lttng/ust-events.h>
#include <lttng/ringbuffer-config.h>
#include <lttng/ust-compiler.h>
#include <lttng/tracepoint.h>
#include <string.h>

2 solutions:
Don't name you provider file like that
OR
Use -idirafter . instead of -I. in the GCC options

(I recommand to implement the later in lttng-gen-tp if the option is available in enough gcc version)

Yannick did you have time to look into this?