Project

General

Profile

Bug #292

Generated header files should not conflict with ust or standard ones.

Added by Matthew Khouzam over 8 years ago. Updated over 6 years ago.

Status:
Confirmed
Priority:
Low
Assignee:
Yannick Brosseau
Target version:
-
Start date:
07/03/2012
Due date:
% Done:

0%

Estimated time:

Description

In Lttng-UST 2.0 if a given tracepoint file (foo.tp) has tracepint_events with domains that are not "foo" the tracepoint will not compile. This would be good to have a warning/error for, since if you don't it will just cause errors in the compilation phase which are very difficult to understand.

#1

Updated by Yannick Brosseau over 8 years ago

  • Status changed from New to Feedback

I cannot reproduce the problem, can you confirm it's not a problem with your setup?
The exact version of LTTng-UST and gcc would be useful.

#2

Updated by Matthew Khouzam over 8 years ago

I have determined that it's when the .tp file is "ust.tp" makes it easier
to check. :)

On Tue, Jul 3, 2012 at 3:52 PM, <> wrote:

Issue #292 has been updated by Yannick Brosseau.

Status changed from New to Needs feedback

I cannot reproduce the problem, can you confirm it's not a problem with
your setup?
The exact version of LTTng-UST and gcc would be useful.
----------------------------------------
Bug #292: Lttng-gen-tp need additional error messages
https://bugs.lttng.org/issues/292#change-589

Author: Matthew Khouzam
Status: Needs feedback
Priority: Normal
Assignee: Yannick Brosseau
Category:
Target version:

In Lttng-UST 2.0 if a given tracepoint file (foo.tp) has tracepint_events
with domains that are not "foo" the tracepoint will not compile. This would
be good to have a warning/error for, since if you don't it will just cause
errors in the compilation phase which are very difficult to understand.

--
You have received this notification because you have either subscribed to
it, or are involved in it.
To change your notification preferences, please click here:
http://bugs.lttng.org/my/account

--
Matthew Khouzam, M.Ing
Embedded Systems Designer

#3

Updated by Yannick Brosseau over 8 years ago

Oh, interesting. I see the problem...

#4

Updated by Yannick Brosseau over 8 years ago

  • Subject changed from Lttng-gen-tp need additional error messages to Generated header files should not conflict with ust or standard ones.
  • Status changed from Feedback to Confirmed
#5

Updated by Mathieu Desnoyers over 7 years ago

Hi Yannick,

This bug has been opened in July 2012. Any ETA for resolution ?

Thanks,

Mathieu

Issue #292 has been updated by Yannick Brosseau.

Subject changed from Lttng-gen-tp need additional error messages to Generated header files should not conflict with ust or standard ones.
Status changed from Needs feedback to Confirmed

----------------------------------------
Bug #292: Generated header files should not conflict with ust or standard ones.
https://bugs.lttng.org/issues/292#change-592

Author: Matthew Khouzam
Status: Confirmed
Priority: Normal
Assignee: Yannick Brosseau
Category:
Target version:

In Lttng-UST 2.0 if a given tracepoint file (foo.tp) has tracepint_events with domains that are not "foo" the tracepoint will not compile. This would be good to have a warning/error for, since if you don't it will just cause errors in the compilation phase which are very difficult to understand.

--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.lttng.org/my/account

--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

#6

Updated by Yannick Brosseau over 7 years ago

Mathieu Desnoyers wrote:

Hi Yannick,

This bug has been opened in July 2012. Any ETA for resolution ?

Trying to find the best solution for this problem.
We could:
- Fail properly and tell the user to choose another file name
- Add a prefix to the generated file name
- Other solutions?

#7

Updated by Mathieu Desnoyers over 7 years ago

If I understand correctly, gen tp should enforce that if a tracepoint provider source file is called

"blah.tp"

then all the tracepoint events it contains should be in the "blah" provider. Am I missing something ?

If this is all that's needed, just printing an error message and exiting from gen tp would seem to be the right approach.

Thanks,

Mathieu

#8

Updated by Yannick Brosseau over 7 years ago

No, that's not the issue here (the original description is missleading).

You can generate tracepoing which have a provider of a name different that the .tp file without any problem.

The problem occurs when you have a tp file call the same of other header.
(I'm still figuring out the exact pattern for the problem)

#9

Updated by Yannick Brosseau over 7 years ago

Some more information:

When using -I. to compile, any file present named as one of the file included by ust-tracepoint-event.h

IE one of these:
#include <stdio.h>
#include <stdlib.h>
#include <urcu/compiler.h>
#include <urcu/rculist.h>
#include <lttng/ust-events.h>
#include <lttng/ringbuffer-config.h>
#include <lttng/ust-compiler.h>
#include <lttng/tracepoint.h>
#include <string.h>

2 solutions:
Don't name you provider file like that
OR
Use -idirafter . instead of -I. in the GCC options

(I recommand to implement the later in lttng-gen-tp if the option is available in enough gcc version)

#10

Updated by Mathieu Desnoyers almost 7 years ago

  • Priority changed from Normal to Low
#11

Updated by Christian Babeux over 6 years ago

Yannick did you have time to look into this?

Also available in: Atom PDF