Project

General

Profile

Actions

Bug #504

closed

Invalid octal escape sequence in trace included in ctf-testsuite

Added by Marc-Andre Laperle almost 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
04/17/2013
Due date:
% Done:

0%

Estimated time:

Description

I cloned this repo
https://github.com/efficios/ctf-testsuite

In traces/ctf-testsuite/tests/pass/succeed3/metadata:

test2 = "?\x20\o040?";

The rule is

octal-escape-sequence:
    \ octal-digit
    \ octal-digit octal-digit
    \ octal-digit octal-digit octal-digit

not

\ o octal-digit
...

So, either this test should go in the fail directory or the 'o' character should be removed. In both cases, babeltrace needs to fixed so that it fails when encountering a \o.

Actions #1

Updated by Marc-Andre Laperle almost 11 years ago

This is now fixed in master but it doesn't seem like I can mark this bug as fixed myself.

Actions #2

Updated by Anonymous almost 11 years ago

  • Status changed from New to Resolved
Actions #3

Updated by Mathieu Desnoyers almost 11 years ago

Fixed by:

commit 697b10505ff455ec93d57868d1b15bcda4d9dd37
Author: Mathieu Desnoyers <>
Date: Wed Apr 17 13:05:21 2013 -0400

Fix: octal and hex string handling
Following C99:
Octal does not start by \o, but rather is in the form:
\n \nn or \nnn
where n is octal.
Hexadecimal is:
\xH \xHH or \xHHH
where H is hexadecimal.
Signed-off-by: Mathieu Desnoyers &lt;&gt;
Actions

Also available in: Atom PDF