Project

General

Profile

Actions

Bug #611

closed

`make check' should be used for unit tests, and not for hours-long benchmarks

Added by Anonymous almost 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
08/01/2013
Due date:
% Done:

100%

Estimated time:

Description

Many distros run the "make check" target as part of their packaging process, to catch bugs that could have been introduced by packaging or other kind of integration (distro patching, etc.) However, the make check target in URCU runs some very long performance (and conformance?) checks, which can easily take many hours. The end result is that distros (Debian in particular) end up disabling the tests altogether, losing said advantages.

"make check" should be reserved for (relatively) quick unit tests. The current benchmarks could be run manually through a script in the source tree. Even if "make check" doesn't do anything right now, if some tests are added eventually, distros won't have to go back and re-enable the target in their packages.

I report this now because it's problematic for the Ubuntu people, who are considering moving URCU to their "main" pocket See:
https://bugs.launchpad.net/ubuntu/+source/liburcu/+bug/1203591
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=718409

Actions #1

Updated by Mathieu Desnoyers almost 11 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF