Project

General

Profile

Bug #655

lttng-tools/src/bin/lttng-sessiond/event.c contains a misleading comment

Added by Daniel U. Thibault over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Low
Assignee:
-
Target version:
Start date:
10/28/2013
Due date:
% Done:

100%

Estimated time:

Description

In lttng-tools/src/bin/lttng-sessiond/event.c (2.3.0 release), lines 246-251, one can read:

/*
 * Enable all kernel tracepoint events of a channel of the kernel session.
 */
int event_kernel_enable_all_syscalls(struct ltt_kernel_channel *kchan,
        int kernel_tracer_fd)
{

This is apparently a cut-and-paste error imported from the preceding function, event_kernel_enable_all_tracepoints. The comment should read instead:

/*
 * Enable kernel syscall tracing events of a channel of the kernel session.
 */
int event_kernel_enable_all_syscalls(struct ltt_kernel_channel *kchan,
        int kernel_tracer_fd)
{

#1

Updated by David Goulet over 6 years ago

  • Status changed from New to Confirmed

Please submit patches for small bugs like that :)

I made one for this one for now. Will push it soon.

#2

Updated by David Goulet over 6 years ago

  • Status changed from Confirmed to Resolved
  • % Done changed from 0 to 100
#3

Updated by Daniel U. Thibault over 6 years ago

David Goulet wrote:

Please submit patches for small bugs like that :)

I made one for this one for now. Will push it soon.

I'd love to do so but I'm not currently set up to produce patch files.

Also available in: Atom PDF