Bug #666
closedFix test flakiness
100%
Description
15:50 < Compudj> not ok 53 - Validate trace for event tp:tptest
15:50 < Compudj> # Failed test 'Validate trace for event tp:tptest'
15:50 < Compudj> # in :() at line 170 fail .//../../../utils/tap/tap.sh.
15:50 < Compudj> # Found 0 occurences of tp:tptest
15:50 < Compudj> reprod here
15:53 < Compudj> test_ust_per_uid_local_snapshot_post_mortem is bad
15:53 < Compudj> we kill the test application possibly before it has produced
any event
15:53 < dgoulet> oh!
15:53 < Compudj> indeed, it will fail in some cases
15:54 < cbab> okay, we will have to fix this and backport it
15:55 < Compudj> dgoulet: we might want to wait until the app has generated
some trace data before killing it.
15:55 < Compudj> dgoulet: have we done something similar in the past ?
15:57 < Compudj> dgoulet: an easy way to get around this: ensure the test app
creates a dummy file (name received as parameter) after it has
hit its first tracepoint
15:57 < Compudj> dgoulet: so we could wait until the file appears before
killing the app
15:57 < Compudj> the filename could be a tmp file name (à la mktemp)
15:58 < dgoulet> hmmm
15:58 < Compudj> we unlink the file after the whole test
15:58 < Compudj> tadaaa :)
Updated by Mathieu Desnoyers about 11 years ago
16:02 < Compudj> this should also allow us to fix the periodical timer flaky
tests
16:02 < Compudj> I think we disabled those
16:02 < Compudj> that same approach should do the trick
Updated by David Goulet almost 11 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Applied in changeset 209b934f27820bff953d663af9bab268dc5e951c.