Project

General

Profile

Actions
Copy link

Bug #668

closed

babeltrace mixes up packet size and content size when only one of those is missing

Added by Mathieu Desnoyers over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
11/18/2013
Due date:
% Done:

0%

Estimated time:

Description

https://github.com/efficios/ctf-testsuite/tree/master/tests/1.8/regression/stream/pass/2-packets-no-content-size

Actions
Copy link
 #1

Updated by Mathieu Desnoyers over 10 years ago

  • Status changed from New to Resolved

Fixed by:

commit 95b34f38fe888222a80b62af6727459ce5f6444c
Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date:   Wed Nov 27 03:38:23 2013 -0500

    Fix: reversed logic in packet vs content size

    As described in CTF section 5.2

    "If the packet size field is missing, the whole stream only contains a
    single packet. If the content size field is missing, the packet is
    filled (no padding). The content and packet sizes include all headers." 

    Here is the correct semantic:

    * Content size and packet size are available:

      Packet is filled with data up to content size, and then with padding
      up to packet size.

    * Content size available, no packet size field:

      The stream has a single packet. It is filled up to content size, and
      the rest is padding.

    * Packet size available, no content size field:

      Packet filled completely, no padding.

    Fixes #683

    Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Actions
Copy link

Also available in: Atom PDF