Project

General

Profile

Actions

Bug #751

closed

Channel names ought to be filtered just like session names

Added by Daniel U. Thibault about 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
High
Target version:
Start date:
03/07/2014
Due date:
% Done:

100%

Estimated time:

Description

Channel names obey the same limit (NAME_MAX) as session names, and since they have pretty much the same role storage-path-wise, they ought to be checked in the same way.

Right now, the only character one cannot include in a channel name is the comma, because the enable-channel command treats it as a channel name separator. Channel names may include spaces, but these need to be escaped in some contexts (e.g. 'lttng disable-channel -k my\ kernel\ channel').

However, it is perfectly legal to create a name like this:

$ lttng enable-channel -k k/../ust/weird

This does not in fact create a misplaced kernel channel file: it creates no file at all, and no warning or error occurs. I haven't checked what happens if that channel is sent to a remote relay daemon, but that would undoubtedly be just as troublesome.

Actions #1

Updated by Christian Babeux over 9 years ago

  • Project changed from LTTng to LTTng-tools
Actions #2

Updated by Christian Babeux over 9 years ago

  • Assignee set to Philippe Proulx
Actions #3

Updated by Anonymous over 9 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset tools|commit:1f345e94095b14037b3f39bc0b48db6b6543efd6.

Actions

Also available in: Atom PDF