Project

General

Profile

Bug #774

Race between ust app list and register done command

Added by David Goulet over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Critical
Assignee:
-
Target version:
Start date:
03/27/2014
Due date:
% Done:

100%

Estimated time:

Description

The "lttng list -u" (lttng_list_tracepoints()) does NOT require a session thus does NOT lock the session list lock and then call the ust app list event function that iterates over the application hash table. However, an application can be in the process of being registered and it's added in the hash table BEFORE the register done command is received from the application thus creating a race window between that expected command and a list command that does not require any lock.

Note, the register done process is protected by the session list lock so we can use sessions safely during a new application registration.

Possible solutions:

1) Use the session list lock for the list tracepoints command.

2) Add a lock that protects the app add command + register done BUT that would require every call site that uses the ust app HT to lock it.

3) Somehow figure out how we can add the application to the HT after the registration is done. Right now, a comment explains why we need it before.

/*
 * Add application to the global hash table. This needs to be
 * done before the update to the UST registry can locate the
 * application.
 */
ust_app_add(app);
#1

Updated by David Goulet over 6 years ago

  • Status changed from Confirmed to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF