Project

General

Profile

Actions

Bug #927

closed

Multiple domain options are allowed in commands where it should not

Added by Philippe Proulx over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Target version:
Start date:
09/01/2015
Due date:
% Done:

100%

Estimated time:

Description

In the enable-channel, disable-channel, enable-event and disable-event commands, it is possible to specify multiple domain options, and only one of them is actually used. The lucky domain to be elected seems to be the oldest one having been implemented in the great history of LTTng, i.e. the following precedence order applies: -k, -u, -j, -l, -p.

Examples:

$ lttng enable-channel -u -k allo 
Kernel channel allo enabled for session a
$ lttng disable-channel -u -k allo 
Kernel channel allo disabled for session a
$ lttng enable-channel -k -u  allo 
Kernel channel allo enabled for session a
$ lttng enable-event -u -j -p -k -l -c allo lol
Kernel event lol created in channel allo
$ lttng disable-event -p -l -u -j -c allo lol
UST event lol disabled in channel allo for session a

Smells like a switch-case.

Actions #1

Updated by Jonathan Rajotte Julien over 8 years ago

  • Project changed from LTTng to LTTng-tools
Actions #2

Updated by Philippe Proulx over 8 years ago

  • Status changed from New to In Progress
  • Assignee set to Philippe Proulx
  • Target version set to 2.7
Actions #3

Updated by Anonymous over 8 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset tools|commit:3ecec76a3cd1eb6b301d03895ab425976ba28dee.

Actions

Also available in: Atom PDF