Project

General

Profile

Actions
Copy link

Bug #701

closed

ust-app.c: 2 * bad if test ?

Added by David Binderman almost 11 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
LTTng - 2.5
Start date:
12/03/2013
Due date:
% Done:

100%

Estimated time:

Description

I just ran the static analyser cppcheck over the
source code of lttng-tools-2.3.0. It said

1.

ust-app.c:3047:5: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

Source code is

if (ret != -LTTNG_UST_ERR_EXITING || ret != -EPIPE) {

Suggest swap || for &&

2.

ust-app.c:3147:5: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

if (ret != -LTTNG_UST_ERR_EXITING || ret != -EPIPE) {

Duplicate.

Actions
Copy link
 #1

Updated by David Goulet almost 11 years ago

Good catch thanks!

I'll push a patch today and backport it accordingly.

Actions
Copy link
 #2

Updated by David Goulet almost 11 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by David Goulet over 10 years ago

  • Target version changed from 15 to 2.5
Actions
Copy link

Also available in: Atom PDF