Project

General

Profile

Actions

Bug #161

closed

Split ctf/event.h

Added by Yannick Brosseau about 12 years ago. Updated about 12 years ago.

Status:
Resolved
Priority:
Normal
Category:
-
Target version:
-
Start date:
03/08/2012
Due date:
% Done:

0%

Estimated time:

Description

The ctf/event.h contains the ctf_iterator and the ctf_event functions

The functions
bt_ctf_iter_create
bt_ctf_get_iter
bt_ctf_iter_destroy
should be in a ctf/iterator.h file
The bt_ctf_iter_read_event should also be there, but I'm not sure

I think the rest belong correctly in event.h

Actions #1

Updated by Yannick Brosseau about 12 years ago

Also, I'm wondering if the events.h should be renamed event.h

Actions #2

Updated by Mathieu Desnoyers about 12 years ago

  • Status changed from New to Resolved

commit 9efd5d766ca00e09bc527a7d75705ac5e2d923d7
Author: Mathieu Desnoyers <>
Date: Thu Mar 8 16:41:32 2012 -0500

API fix: Move ctf iterator API members to new babeltrace/ctf/iterator.h
They did not belong in babeltrace/ctf/event.h.
(Closes #161)
Reported-by: Yannick Brosseau &lt;&gt;
Signed-off-by: Mathieu Desnoyers &lt;&gt;
Actions #3

Updated by Yannick Brosseau about 12 years ago

The C files should also be splited if you want to ease maintenance in the long term and not get a mess like lttv! :-)

Actions #4

Updated by Mathieu Desnoyers about 12 years ago

commit a7765dd4491b15629e3884493db0f29611b84e65
Author: Mathieu Desnoyers <>
Date: Mon Mar 12 10:21:26 2012 -0400

Fix: split ctf/event.c
Ensure the implementation follows the API event.h/iterator.h split.
closes #161
Reported-by: Yannick Brosseau &lt;&gt;
Signed-off-by: Mathieu Desnoyers &lt;&gt;
Actions

Also available in: Atom PDF