Activity
From 03/27/2024 to 04/25/2024
Today
- 04:44 PM LTTng-tools Revision a881d7c9 (lttng-tools): vscode: Add configurations to run the executables under the debugger
- Add tasks.json and launch.json which allow VSCode users to build the
project and run the various binaries (lttng, ltt... - 01:50 PM Babeltrace Revision f79594fd (babeltrace): .clang-tidy: add some checks
- These checks seem reasonable, enable them.
Change-Id: I4ed416a9deee2385af38c305a125cd616ec94aa0
Signed-off-by: Simon... - 01:50 PM Babeltrace Revision c0db1f10 (babeltrace): bt2::CommonEnumerationFieldClass::addMapping(): add missing static assertion
- Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Change-Id: Ie5a90126d0c25c92f00dce0af962f1e64048bdbc
Reviewe... - 09:21 AM Babeltrace Revision e27adb90 (babeltrace): cpp-common/bt2c/logging.hpp: remove no-formatting ("str") alternatives
- This patch removes everything named bt2c::Logger::log*Str*() and
BT_CPPLOG*STR*().
The no-formatting versions existe... - 09:21 AM Babeltrace Revision e40ac8f6 (babeltrace): Fix: cpp-common/bt2c/logging.hpp: add missing `template` keyword
- In very specific contexts, it's possible that a `bt2c::Logger` reference
is a dependent type, for example:
templ...
04/24/2024
- 05:04 PM Babeltrace Revision eced29fc (babeltrace): Keep a single `.gitignore` file
- We have a few arbitrary directory-specific `.gitignore` files and I'd
like to keep things consistent here: either ded... - 05:04 PM Babeltrace Revision 3b4f52ad (babeltrace): .gitignore: categorize rules and sort them per category
- Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Change-Id: I4a80709271b189469ba6b3869410ff41196ae551
Reviewe... - 05:04 PM Babeltrace Revision fed63719 (babeltrace): .gitignore: ignore all `*.egg-info`
- Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Change-Id: I804bbb158ba2ccb5dbe326b4eb12d5e13d06c62a
Reviewe... - 05:04 PM Babeltrace Revision d97afa4a (babeltrace): .gitignore: ignore all `/src/plugins/ctf/[...]/tsdl/parser.*pp`
- Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Change-Id: I3d8e45d6a8482552d11c7292ddcdb21514e683b9
Reviewe... - 05:04 PM Babeltrace Revision b75e024e (babeltrace): .gitignore: ignore all `/src/cli/*.bin`
- Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Change-Id: Ie1c0138d2a1d766c386b4c237545b21a9903c027
Reviewe... - 05:04 PM Babeltrace Revision eabba042 (babeltrace): .gitignore: cleanup test files
- Given that, under the `tests` directory:
✔ All shell file names end with `.sh`.
✔ All C file names end with `.c` or ... - 04:38 PM Babeltrace Revision 580c25a5 (babeltrace): tests: test_dwarf.c: initialize `tag` variable
- On Arch Linux, When configuring with:
$ /home/smarchi/src/babeltrace/configure CFLAGS='-O2 -flto=auto' LDFLAGS='... - 04:36 PM LTTng-tools Revision 9a28bc04 (lttng-tools): Tests: Add test to check shared-memory FD leaks after relayd dies
- Refs: https://bugs.lttng.org/issues/1411
Change-Id: I9804011320c28a9867af1fdc6a8d82ad0671fe3d
Signed-off-by: Kienan ... - 04:35 PM LTTng-tools Revision e793ddc8 (lttng-tools): Fix: consumerd: leak of tracing buffers on relayd connectivity issue
- Observed issue
==============
A leak of the tracing buffers can be noticed when the relay daemon is
terminated follo... - 02:11 AM Babeltrace Revision e6767949 (babeltrace): cpp-common/bt2c: remove `dummy.cpp`
- There is another source file (file-utils.cpp), so dummy.cpp is no longer
needed.
Change-Id: I7429a005c49498d6d2e500c...
04/23/2024
- 07:07 PM Babeltrace Revision dafde0c1 (babeltrace): .gitignore: add missing test binaries
- Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Change-Id: Ie78f6483a0e3810535ed8611d4cb033ca96b9b4b
Reviewe... - 07:07 PM Babeltrace Revision 53e1ecce (babeltrace): bt2c/logging.hpp: use `std::span<const std::uint8_t>` for mem. data
- `std::span<const std::uint8_t>` is also the `bt2c::Logger::MemData`
alias.
Adapt `src/plugins/ctf/common/src/msg-ite... - 07:07 PM Babeltrace Revision 88534b92 (babeltrace): CONTRIBUTING.adoc: mention bt2c::makeSpan()
- Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Change-Id: I6b5340fd353cbd4ef40f9e75322588842f10a788
Reviewe... - 07:07 PM Babeltrace Revision c458c630 (babeltrace): src/cpp-common/bt2c: rename `span.hpp` -> `make-span.hpp`
- bt2c::makeSpan() is the only thing `make-span.hpp` offers.
Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
... - 07:07 PM Babeltrace Revision 2be8c93e (babeltrace): CONTRIBUTING.adoc: "make_unique" -> "make-unique"
- Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Change-Id: I2528ff4bfbb0cb101e34373d36a50b4b27100f1c
Reviewe... - 07:07 PM Babeltrace Revision b5acd2ad (babeltrace): cpp-common/bt2c/logging.hpp: use camel case for param. names
- Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Change-Id: I1d73559b1512d60d9e0ed87870cb8f375138e3d0
Reviewe... - 07:07 PM Babeltrace Revision 24ce7ecb (babeltrace): bt2c::Logger: make `Level` enumerators more readable
- Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Change-Id: I7f69a587af353446a25392684b85939afe8d1210
Reviewe... - 11:21 AM Bug #1413: lttng-sessiond is reporting error in syslog file while terminating the same process using systemd
- Hi Sougata,
I should have been clearer, my apologies.
With the @systemctl stop frr@, is an equivalent command t... - 11:03 AM Babeltrace Revision 1dcaf4b7 (babeltrace): tests: LD_PRELOAD libstdc++.so in bt_run_in_py_env
- With an ASan build on Debian 12 or Ubuntu 22.04 (and probably others),
some tests (test-query-trace-info.sh, test-pyt... - 10:36 AM LTTng-UST Revision 97572c04 (lttng-ust): Introduce LTTNG_UST_MAP_POPULATE_POLICY environment variable
- Problem Statement
-----------------
commit 4d4838bad480 ("Use MAP_POPULATE to reduce pagefault when available")
was ...
04/22/2024
- 10:50 PM Bug #1413: lttng-sessiond is reporting error in syslog file while terminating the same process using systemd
- sudo systemctl stop frr <<< This is the command to stop frr service
sudo systemctl stop lttng-sessiond ...
04/19/2024
- 11:19 AM LTTng-UST Revision 4b01076f (lttng-ust): Add close_range wrapper to liblttng-ust-fd.so
- glibc 2.34 implements close_range(2), which is used by the ssh client
(amongst others). This needs to be overridden t...
04/18/2024
- 12:41 PM Bug #1413 (Feedback): lttng-sessiond is reporting error in syslog file while terminating the same process using systemd
- Hi Sougata,
what commands are used by your systemd service (@frr.service@) to stop lttng-sessiond?
thanks,
kienan - 12:26 PM Bug #1413 (Feedback): lttng-sessiond is reporting error in syslog file while terminating the same process using systemd
- Hi,
I am getting below errors in /var/log/syslog file after systemctl stop lttng-sessiond. Please re-assign to act...
04/17/2024
- 01:57 PM Babeltrace Revision 60323499 (babeltrace): src.ctf.lttng-live: remove some goto error-handling
- Change-Id: I9b6d967d54c63d7f7544bb0d1a1eb778a8df64d4
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision a97176ef (babeltrace): src.ctf.lttng-live: viewer-connection.cpp: remove goto error-handling
- Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I87b05835a268fef92f906c16bb35a84c1df0a27f
Reviewed... - 01:57 PM Babeltrace Revision e5694f0e (babeltrace): src.ctf.lttng-live: use viewer_connection_close_socket more
- Use viewer_connection_close_socket at all spots we close the control
socket, to de-duplicate code a little bit.
Sign... - 01:57 PM Babeltrace Revision 5ad6219b (babeltrace): src.ctf.lttng-live: make queries report errors with exceptions
- Change-Id: Ibf633312304a6353842baa569860a2e1216785b0
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision bf35aaef (babeltrace): src.ctf.lttng-live: make queries output a bt2::Value
- Change-Id: If0baec1ca712e75e5873cc6c3e88cec18bb4f424
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision b80bdfe5 (babeltrace): src.ctf.lttng-live: use C++ value wrappers for query parameters
- Change-Id: Ie64cef32650dbc62238429b10c30a0c8ffd5dac3
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 9d0b798a (babeltrace): src.ctf.lttng-live: add bt_common_lttng_live_url_parts_deleter
- bt_common_lttng_live_url_parts can't be made a C++ object that
automatically manages its memory yet, since it's used ... - 01:57 PM Babeltrace Revision 7aed4059 (babeltrace): src.ctf.lttng-live: introduce lttng_live_msg_iter::UP and use it
- Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Change-Id: Ie87efb7a6599a738dad60cc3533f8440c283da6c
Reviewed... - 01:57 PM Babeltrace Revision 8ad3f6e0 (babeltrace): src.ctf.lttng-live: add lttng_live_msg_iter destructor
- Convert lttng_live_msg_iter_destroy to a destructor.
Change-Id: I4bd28e540517e11ede6c210c7645db98951c31f8
Reviewed-o... - 01:57 PM Babeltrace Revision d721bef8 (babeltrace): src.ctf.lttng-live: introduce live_viewer_connection::UP and use it
- Change lttng_live_msg_iter::viewer_connection to be a
live_viewer_connection::UP and convert live_viewer_connection_c... - 01:57 PM Babeltrace Revision 277bcb7f (babeltrace): src.ctf.lttng-live: add live_viewer_connection destructor
- Convert live_viewer_connection_destroy into a destructor.
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Ch... - 01:57 PM Babeltrace Revision 198e7911 (babeltrace): src.ctf.lttng-live: make live_viewer_connection::{relay_hostname,target_hostname,session_name,proto} GStringUPs
- These values come from GStrings from the common code, not yet C++-ified,
so it's simpler for now to use GStringUP to ... - 01:57 PM Babeltrace Revision 30d81897 (babeltrace): src.ctf.lttng-live: make live_viewer_connection::url an std::string
- Change-Id: I863b77f2b109312809df088adf374461550aac88
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 751aaa62 (babeltrace): src.ctf.lttng-live: make lttng_live_msg_iter::sessions an std::vector
- Change-Id: I1c6f23eb1cad89d431699b07ce68673ae9f19963
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 459dcd39 (babeltrace): src.ctf.lttng-live: introduce lttng_live_session::UP and use it
- Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Change-Id: Ie270049fe8923f7608f372de4b459b645806367e
Reviewed... - 01:57 PM Babeltrace Revision c28da405 (babeltrace): src.ctf.lttng-live: add lttng_live_session destructor
- Convert lttng_live_destroy_session to a destructor. Add a new
lttng_live_destroy_session function that calls delete,... - 01:57 PM Babeltrace Revision 220476b8 (babeltrace): src.ctf.lttng-live: make lttng_live_session::{hostname,session_name} std::strings
- Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I5b0dd1b99d741042b0b2b37a48251ea96d4b3d4f
Reviewed... - 01:57 PM Babeltrace Revision 6dcda123 (babeltrace): src.ctf.lttng-live: make lttng_live_session::traces an std::vector
- Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I3b8ec1e61929fad1e024955dcfc6708cb125b5c9
Reviewed... - 01:57 PM Babeltrace Revision deb86334 (babeltrace): src.ctf.lttng-live: introduce lttng_live_trace::UP and use it
- Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I0008ee962a004ac6e215a5ed32c15b6367fb245b
Reviewed... - 01:57 PM Babeltrace Revision db00b877 (babeltrace): src.ctf.lttng-live: make lttng_live_trace::stream_iterators an std::vector
- Change-Id: I745900032bc5d880a305e434afaeaeaef728708d
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 6eeff3ca (babeltrace): src.ctf.lttng-live: introduce and use lttng_live_stream_iterator::UP
- Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I50c0db7fb4a86d5081a3c049e1dc76b6311507aa
Reviewed... - 01:57 PM Babeltrace Revision ce4ee876 (babeltrace): src.ctf.lttng-live: add lttng_live_stream_iterator destructor
- lttng_live_stream_iterator_destroy is still used for a GPtrArray, so it
is kept as a wrapper to the destructor for no... - 01:57 PM Babeltrace Revision 35e432d7 (babeltrace): src.ctf.lttng-live: make lttng_live_stream_iterator::current_msg a bt2::Message::Shared
- Adjust a bunch of related functions involved in creating the message
that ends up there.
Signed-off-by: Simon Marchi... - 01:57 PM Babeltrace Revision f8a11f24 (babeltrace): ctf: remove tabs used for indentation
- These are leftovers from commit 4164020e790f ("Re-format new C++
files").
Change-Id: I3a3dbda6c983308c1403c3649913a6... - 01:57 PM Babeltrace Revision e28ca558 (babeltrace): src.ctf.lttng-live: make lttng_live_stream_iterator::name an std::string
- Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I515319dc62f147e4423c9eadd3dc00648e46e789
Reviewed... - 01:57 PM Babeltrace Revision afbf59c4 (babeltrace): src.ctf.lttng-live: make lttng_live_stream_iterator::buf an std::vector
- Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I944475345ed8dd5b1ae2824eb86cf9ead56cd92f
Reviewed... - 01:57 PM Babeltrace Revision 2d5d8c7b (babeltrace): src.ctf.lttng-live: make lttng_live_stream_iterator::msg_iter a ctf_msg_iter_up
- Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I603a9daa109ebab118fe72e38ac175a7f7006335
Reviewed... - 01:57 PM Babeltrace Revision 0b68f2bc (babeltrace): src.ctf.lttng-live: make lttng_live_stream_iterator::stream a bt2::Stream::Shared
- Change-Id: Ia38f2feba1040749df692574e67861c81a73e8df
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision e66be7c3 (babeltrace): src.ctf.lttng-live: introduce lttng_live_metadata::UP and use it
- Change-Id: I3f902be075b8274485b6ce88b1b7fa1617e79cff
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision ef9e5f5d (babeltrace): src.ctf.lttng-live: introduce lttng_live_component::UP and use it
- Change-Id: I1bdc817239fbba02fae9696e51559daa6b1b43b9
Reviewed-on: https://review.lttng.org/c/babeltrace/+/8452
Review... - 01:57 PM Babeltrace Revision bf81b18f (babeltrace): src.ctf.lttng-live: remove lttng_live_component_destroy_data
- Change-Id: I9e57187adcaba990c1f48885cc6e8e94f96c0ac3
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 2780ec75 (babeltrace): src.ctf.lttng-live: change lttng_live_component::params::url to std::string
- Change-Id: I5b5c7c15e99bd9cc79c5e20ea68326a244490ce8
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision d961ecea (babeltrace): src.ctf.fs: make create_streams_for_trace use bt2::StreamClass to instantiate streams
- Wrap the stream class (ds_file_group->sc->ir_sc) in a bt2::StreamClass,
then use that to instantiate streams.
Change... - 01:57 PM Babeltrace Revision f9b673b0 (babeltrace): src.ctf.fs: pass path to ctf_fs_ds_index_entry constructor
- Change-Id: Id8c29f502cc126775e2ded67813a6f8714f06705
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 86c82636 (babeltrace): src.ctf.fs: remove ctf_fs_ds_file_group_create, add constructor
- Replace ctf_fs_ds_file_group_create with an equivalent constructor.
Change-Id: I06d69a05ba685552dc2d6b78800d79f20569... - 01:57 PM Babeltrace Revision f9f2dd71 (babeltrace): src.ctf.fs: change a pointer parameter to a reference, remove unused parameter
- - Change add_range's range parameter to a const ref.
- Remove the output parameter of populate_stream_info, its call... - 01:57 PM Babeltrace Revision 994183de (babeltrace): ctf: convert ctx_destroy to ~ctf_visitor_generate_ir
- Convert ctx_destroy into a destructor for ctf_visitor_generate_ir.
Change-Id: I7963276587e44621381c3b47a734986c1696d... - 01:57 PM Babeltrace Revision e1d200e5 (babeltrace): src.ctf.fs: pass clkClsCfg to ctf_fs_component constructor
- Change-Id: I3a9d696780d044505d273a28804915bf2f9e9c16
Reviewed-on: https://review.lttng.org/c/babeltrace/+/8422
Review... - 01:57 PM Babeltrace Revision c5a5a936 (babeltrace): src.ctf.fs: modernize read_src_fs_parameters
- - Change the input parameter `params` to be bt2::ConstMapValue.
- Changethe return type to be of a new structure typ... - 01:57 PM Babeltrace Revision bf18373f (babeltrace): src.ctf.fs: change two functions to take ctf_fs_ds_index by reference
- Change-Id: I76211e8fb321b87618cccb23e547982b80535c91
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 68c97144 (babeltrace): src.ctf.fs: make set_trace_name use bt2::Trace
- Add an out-of-class `operator+=` to append a `bt2c::CStringView` to an
`std::string`. Without it, I get:
CXX ... - 01:57 PM Babeltrace Revision 6838d8aa (babeltrace): src.ctf.lttng-live: use GCharUP in lttng_live_component_create
- Change-Id: Ieffb41481d6696c46fd51483414a59fae1099ede
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 6954b97e (babeltrace): ctf: make ctf_trace_class_configure_ir_trace use bt2::Trace
- Use the bt2::Trace wrapper instead of a raw `bt_trace *`. Change the
return type to void, since failures are now rep... - 01:57 PM Babeltrace Revision 7916e7eb (babeltrace): src.ctf.lttng-live: make lttng_live_trace::trace a bt2::Trace::Shared
- Use the C++ wrapper to hold the reference to the trace.
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Chan... - 01:57 PM Babeltrace Revision a52f1f2e (babeltrace): src.ctf.lttng-live: make lttng_live_trace::trace_class a bt2::TraceClass::Shared
- Use the C++ wrapper to hold the reference to the trace class.
Note that the existing comment said it is a weak refer... - 01:57 PM Babeltrace Revision 4181bd5d (babeltrace): src.ctf.lttng-live: use std::string in list_append_session
- Use `fmt::format` to create a temporary `std::string`.
Change-Id: I2a930cff82e4f43ff303f62a7371eb67d8144c04
Signed-o... - 01:57 PM Babeltrace Revision 76edb16f (babeltrace): src.ctf.lttng-live: use std::vector in lttng_live_get_one_metadata_packet
- Use an std::vector to manage the buffer used to store the received data.
Change-Id: I04f99440573c722d982378ef9d8bb47... - 01:57 PM Babeltrace Revision 15fcc425 (babeltrace): src.ctf.lttng-live: lttng_live_metadata_update: use std::vector as metadata buffer
- Use an std::vector to store the metadata contents in
lttng_live_metadata_update, instead of opening a memstream. Mod... - 01:57 PM Babeltrace Revision 1cb63a52 (babeltrace): src.ctf.fs: make ds_file_group_insert_ds_file_info_sorted a method of ctf_fs_ds_file_group
- Change-Id: I743359a80d39e307f4aa36b2deaa92429c536cea
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 032fc0ad (babeltrace): src.ctf.fs: fs.cpp: declare variables on first use
- Move variable declarations to be at or closer to their first use.
Change-Id: Iec7b1789a9cd007938b992292ad48a09d23f79... - 01:57 PM Babeltrace Revision 3ecf3ba0 (babeltrace): src.ctf.fs: data-stream-file.cpp: declare variables on first use
- Move variables declarations to be at or closer to their first use.
Change-Id: I0649c4fda3b42c6bca02217481c08b575fda6... - 01:57 PM Babeltrace Revision c46b32d8 (babeltrace): src.ctf.fs: remove ctf_fs_ds_index::UP
- We don't need to dynamically allocate ctf_fs_ds_index objects, we can
store / return / pass objects directly. Remove... - 01:57 PM Babeltrace Revision 0011731e (babeltrace): src.ctf.fs: store index entry objects instead of pointers
- Store `ctf_fs_ds_index_entry` objects in a flag vector, instead of a
vector of pointers.
Change-Id: I4fea078cddf9729... - 01:57 PM Babeltrace Revision 5f83599b (babeltrace): src.ctf.fs: remove ctf_fs_ds_index_entry_create
- This function is now a simple wrapper around constructing a
ctf_fs_ds_index_entry, remove it.
Change-Id: I2090586487... - 01:57 PM Babeltrace Revision 8bcfc7d7 (babeltrace): src.ctf.fs: initialize ctf_fs_ds_index_entry::packet_seq_num to UINT64_MAX in class
- Initialize the field directly to the right value. The field was
originally initialized to 0 to mimic the g_new0 beha... - 01:57 PM Babeltrace Revision 08bbca9a (babeltrace): src.ctf.fs: remove goto error handling from data-stream-file.cpp
- Same as previous patch, but for data-stream-file.cpp.
Change-Id: Ieb52faca6142ff33591fce2d880bcde664f2c1b7
Signed-of... - 01:57 PM Babeltrace Revision 7d332839 (babeltrace): src.ctf.fs: remove goto error handling from fs.cpp
- gotos prevent declaring variables in the middle of functions, which is
sometimes necessary in C++. Remove gotos used... - 01:57 PM Babeltrace Revision fbd12812 (babeltrace): src.ctf.fs: use GMappedFileUP in build_index_from_idx_file
- Change-Id: I24d4cf509839923e704870953b6c9fb379cf1880
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision a6d50870 (babeltrace): src.ctf.fs: use std::string in build_index_from_idx_file
- Change-Id: Ifdb2c818f66efbc328b095408ae2834646fba4fe
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision ffb66082 (babeltrace): src.ctf.fs: use GCharUP in build_index_from_idx_file
- Change-Id: Ifb4e1b3ac7d484af2d570d75cff21e310f752add
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 19d9bb23 (babeltrace): src.ctf.fs: remove ctf_fs_ds_index_create
- Remove ctf_fs_ds_index_create, since it's now just a wrapper around
constructing a ctf_fs_ds_index.
Change-Id: Ia256... - 01:57 PM Babeltrace Revision 5e502e99 (babeltrace): src.ctf.fs: remove ctf_fs_component_create
- Remove this function, as it's now a simple wrapper around constructing a
ctf_fs_component.
Change-Id: Ifc6c751ff66f4... - 01:57 PM Babeltrace Revision 4726b1ee (babeltrace): src.ctf.fs: remove ctf_fs_file_create
- Remove this function, it's now just a wrapper around constructing a
ctf_fs_file.
Change-Id: I95e4d6eb26b0d359e0f480c... - 01:57 PM Babeltrace Revision 3045bbcb (babeltrace): src.ctf.fs: make ctf_fs_make_port_name return std::string
- Change-Id: I9e2f4d2ac47e4f061e5dda1a3813d1a092ffe433
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 58847744 (babeltrace): src.ctf.fs: use GDirUp in create_ds_file_groups
- Change-Id: I0d0ca566d8123e8419a9345f78224f92f17e9a47
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 8c65d462 (babeltrace): src.ctf.fs: use std::vector<std::string> in ctf_fs_component_create_ctf_fs_trace
- Change-Id: I51af73cb2bdaf10318b19aa493129bdb8401cc3b
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 8bf95988 (babeltrace): src.ctf.fs: use std::string in path_is_ctf_trace
- Change-Id: I796d135f7daee29a4481e61cf073e8bbd2e0f05f
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 3f7d65ef (babeltrace): src.ctf.fs: use std::string in set_trace_name
- Change-Id: Ib44748ebda40b197d5ef0ca20d23b55496c3e918
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 2873fb8f (babeltrace): src.ctf.fs: make get_stream_instance_unique_name return `const std::string &`
- We always return the first stream's name. Return a reference to that
name instead of a new object and a copy of the ... - 01:57 PM Babeltrace Revision c8ca3c11 (babeltrace): src.ctf.fs: use GStringUP in ctf_fs_component_create_ctf_fs_trace_one_path
- Change-Id: I6405c80bdfc519fe45ebadadcfd2e396da9a74cb
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision e001dd28 (babeltrace): src.ctf.fs: remove ctf_fs_trace_destroy
- Remove it and the custom deleter, since ctf_fs_trace instances can now
be simply deleted.
Change-Id: I59f3f89b4b3fae... - 01:57 PM Babeltrace Revision 2dba3a29 (babeltrace): src.ctf.fs: make ctf_fs_trace::metadata a unique_ptr
- Introduce ctf_fs_metadata::UP and change the ctf_fs_trace::metadata
field to be of that type.
Change-Id: I0221ef7786... - 01:57 PM Babeltrace Revision 1b19849c (babeltrace): src.ctf.fs: remove ctf_fs_metadata_init and ctf_fs_metadata_fini
- Change-Id: Ie34c0a5c5aea60aa2fc771d35a39b61ec0eca336
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision ded1f3d6 (babeltrace): src.ctf.fs: make ctf_fs_metadata::trace_class a bt2::TraceClass::Shared
- Change-Id: I1ee6a21525757197213c35acfa1f0a17d7052541
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 70923576 (babeltrace): src.ctf.fs: make ctf_visitor_generate_ir::trace_class a bt2::TraceClass::Shared
- Change-Id: I9b414384b025f39c3cfb9900659235a17426b649
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision bd15f4ba (babeltrace): src.ctf.fs: remove ctf_fs_metadata::text
- Change-Id: Id15010c2d5c1f9fccd60adfb0920b1dca2f2074b
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision cee8a466 (babeltrace): src.ctf.fs: make ctf_fs_trace::path an std::string
- Change-Id: I9938c37f4effca7e83ed2e495feb5dd596d2320e
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision adf452d1 (babeltrace): src.ctf.fs: introduce and use ctf_fs_msg_iter_data::UP
- Introduce ctf_fs_msg_iter_data::UP and use it in ctf_fs_iterator_init
and ctf_fs_iterator_finalize.
Change-Id: I448c... - 01:57 PM Babeltrace Revision 6d4acae3 (babeltrace): src.ctf.fs: use ctf_msg_iter_up in decode_clock_snapshot_after_event
- Change-Id: I4f230d16b96764d5097cb30b8a063d41268bb237
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 4420a5b6 (babeltrace): src.ctf.fs: use ctf_msg_iter_up in add_ds_file_to_ds_file_group
- Change-Id: I3970358b6eab556fd5971d94a8e35b720c6f9450
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 537fddc0 (babeltrace): src.ctf.fs: make ctf_fs_msg_iter_data::msg_iter a ctf_msg_iter_up
- Change-Id: I44ef5f74fdee99a4bf5962cf03757acc7ba774b2
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 657f1bd6 (babeltrace): src.ctf.fs: make ctf_msg_iter_create return a unique_ptr
- Introduce ctf_msg_iter_up, a unique_ptr type with a deleter that calls
ctf_msg_iter_destroy. Make ctf_msg_iter_creat... - 01:57 PM Babeltrace Revision 57ec0a35 (babeltrace): src.ctf.fs: remove ctf_fs_destroy
- Remove it, since a ctf_fs_destroy instance can simply be deleted.
Change-Id: Ic6b879dbdff5e5172c2f07c810f97ceaf45a77... - 01:57 PM Babeltrace Revision 2db013e0 (babeltrace): src.ctf.fs: remove ctf_fs_ds_group_medops_data_destroy
- Remove it, simply delete `data` in the custom deleter. Note that we
still use a custom deleter because ctf_fs_ds_gro... - 01:57 PM Babeltrace Revision 3cf88182 (babeltrace): src.ctf.fs: make ctf_fs_ds_group_medops_data_create return a unique_ptr
- Introduce ctf_fs_ds_group_medops_data_up, a unique_ptr type with a
deleter that calls ctf_fs_ds_group_medops_data_des... - 01:57 PM Babeltrace Revision 55ea683f (babeltrace): src.ctf.fs: make ctf_fs_ds_group_medops_data::file a ctf_fs_ds_file::UP
- Change-Id: Ibe6b3882c29725f7563fb141bd823ec2adeabc6a
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 884feb7c (babeltrace): src.ctf.fs: use ctf_fs_ds_file::UP in add_ds_file_to_ds_file_group
- Change-Id: I8b7a55f28b746cc6b93bfb4459bfc41789d7d4f2
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 21c7fd8b (babeltrace): src.ctf.fs: use ctf_fs_ds_file::UP in decode_clock_snapshot_after_event
- Change-Id: I0b476dd18ee4dfd53ac7bffb12d9fae9b1a1b359
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 89f88383 (babeltrace): src.ctf.fs: make ctf_fs_ds_file_create return a unique_ptr
- Introduce ctf_fs_ds_file::UP, make ctf_fs_ds_file_create return it.
Change-Id: I0139e9504d65425bf53fb21a5b81a4e48da4... - 01:57 PM Babeltrace Revision 3199f1ba (babeltrace): src.ctf.fs: rename ctf_fs_ds_file_destroy to ~ctf_fs_ds_file
- This makes the ctf_fs_ds_file type deletable.
Change-Id: Ibaedb136777a39db11a1bd30355c7123e186e489
Signed-off-by: Si... - 01:57 PM Babeltrace Revision bf3ab6f6 (babeltrace): src.ctf.fs: remove ctf_fs_file_destroy
- Remove it, and the custom deleter, now that a ctf_fs_file can be simply
deleted.
Change-Id: Iaef8b0cdbe525272019e025... - 01:57 PM Babeltrace Revision a39d9817 (babeltrace): src.ctf.fs: make ctf_fs_file::path an std::string
- Change-Id: Ifbe7cd2c184031465428c28701131a82ba219b02
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 85a25425 (babeltrace): src.ctf.fs: make ctf_fs_file::fp a FileUP
- Change-Id: I7c0467a20942cf107d8f10951c8a393e3da7c608
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision b4dec6b2 (babeltrace): src.ctf.fs: make get_file return ctf_fs_file::UP
- Change-Id: I9f115907d062db0a227a49adb7d5786342ca4147
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 2b6f09e0 (babeltrace): src.ctf.fs: use ctf_fs_file::UP in create_ds_file_groups
- Change-Id: I45b50e6c808d5ae17ac755b96e03f260a0972c15
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision c44dc433 (babeltrace): src.ctf.fs: make ctf_fs_ds_file::file a ctf_fs_file::UP
- Change-Id: Id6a62715e3e2a29216debe1c72986215d7f47459
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 5ff12b25 (babeltrace): src.ctf.fs: make ctf_fs_file_create return a unique_ptr
- Introduce ctf_fs_file::UP, make ctf_fs_file_create return that, adjust
impacted callers.
Change-Id: Ice241fd596af3d5... - 01:57 PM Babeltrace Revision 97601f8e (babeltrace): src.ctf.fs: move ctf_fs_file to file.hpp
- This helps resolve some cyclic include problem between file.hpp and
fs.hpp in the next patches (and I think it makes ... - 01:57 PM Babeltrace Revision 265d4ba2 (babeltrace): src.ctf.fs: make ctf_fs_ds_file::stream a bt2::Stream::Shared
- Change-Id: I2df309d73c7a1b987e4d25c63251e13bf47a38a3
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 235f9fd9 (babeltrace): src.ctf.fs: remove ctf_fs_ds_file_group_destroy
- Remove ctf_fs_ds_file_group_destroy and the custom deleter, now that
ctf_fs_ds_file_group can be simply deleted.
Cha... - 01:57 PM Babeltrace Revision be215bcd (babeltrace): src.ctf.fs: make ctf_fs_ds_file_group::stream a bt2::Stream::Shared
- Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I0f84b26ccf43b0469da15946fa825a1255e7ab3d
Reviewed... - 01:57 PM Babeltrace Revision bfd852f0 (babeltrace): src.ctf.fs: remove ctf_fs_ds_index_destroy
- Remove ctf_fs_ds_index_destroy and ctf_fs_ds_index_deleter, since
ctf_fs_ds_index objects can simply be deleted now.
... - 01:57 PM Babeltrace Revision 2fb7af12 (babeltrace): src.ctf.fs: make ctf_fs_ds_index::entries a vector of ctf_fs_ds_index_entry::UP
- Change-Id: If56c5ab6c35b6d93bf38b264f384496d2d06f4eb
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision c05e1405 (babeltrace): src.ctf.fs: make ctf_fs_ds_index_entry_create return a unique_ptr
- Introduce ctf_fs_ds_index_entry::UP and make
ctf_fs_ds_index_entry_create return that. Modify a few functions in
dat... - 01:57 PM Babeltrace Revision fe2f9cda (babeltrace): src.ctf.fs: make ctf_fs_ds_file_group::index a ctf_fs_ds_index::UP
- Change that field to be a unique_ptr. Adjust some functions in fs.cpp
around that.
Signed-off-by: Simon Marchi <sim... - 01:57 PM Babeltrace Revision 441fa755 (babeltrace): src.ctf.fs: make ctf_fs_ds_index_create return a unique_ptr
- Introduce ctf_fs_ds_index::UP, a unique_ptr with a deleter that calls
ctf_fs_ds_index_destroy. Make ctf_fs_ds_index_... - 01:57 PM Babeltrace Revision f3d74124 (babeltrace): src.ctf.fs: make ctf_fs_ds_file_group::ds_file_infos a vector of ctf_fs_ds_file_info::UP
- Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I8df18be3ea1e78c78a8f0e7f0bfe1d43c390555b
Reviewed... - 01:57 PM Babeltrace Revision 2cef6403 (babeltrace): src.ctf.fs: make ctf_fs_ds_file_info_create return a unique_ptr
- Introduce ctf_fs_ds_file_info::UP, make ctf_fs_ds_file_info_create
return it. We don't need a custom deleter, becaus... - 01:57 PM Babeltrace Revision 4d199954 (babeltrace): src.ctf.fs: make ctf_fs_ds_file_info::path an std::string
- Change-Id: If7e5c09024451b1c344a0446a75703929aff480e
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision cdf7de78 (babeltrace): src.ctf.fs: make ctf_fs_trace::ds_file_groups a vector of ctf_fs_ds_file_group::UP
- Replace the GPtrArray with an std::vector of unique_ptr, simplifying
memory management.
Signed-off-by: Simon Marchi ... - 01:57 PM Babeltrace Revision fe2e19c4 (babeltrace): src.ctf.fs: make ctf_fs_ds_file_group_create return a ctf_fs_ds_file_group::UP
- Introduced ctf_fs_ds_file_group::UP, a unique_ptr type with a deleter
that calls ctf_fs_ds_file_group_destroy. Chang... - 01:57 PM Babeltrace Revision 945312a2 (babeltrace): src.ctf.fs: make ctf_fs_component::port_data a vector
- Replace a GPtrArray with a vector of unique pointers of
ctf_fs_port_data, simplifying memory management.
Change-Id: ... - 01:57 PM Babeltrace Revision 873c329a (babeltrace): src.ctf.fs: move `ctf_fs_ds_*` structures and functions to data-stream-file.hpp
- Change-Id: I15392536482968db492fe806ee5fa5e0ecff643e
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision a4c955d9 (babeltrace): src.ctf.fs: switch to using ctf_fs_trace::UP where possible
- Change a few function in fs.cpp to use ctf_fs_trace::UP. Change a use of
GPtrArray to an std::vector.
Signed-off-by... - 01:57 PM Babeltrace Revision 2ca337f1 (babeltrace): src.ctf.fs: make ctf_fs_trace_create return ctf_fs_trace::UP
- Change-Id: I342285ece6b6d68c2375658cb0aff2b363b4b156
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 7df773f2 (babeltrace): src.ctf.fs: make ctf_fs_component::trace a unique_ptr
- Define ctf_fs_trace::UP to be a unique_ptr type with a deleter that
calls ctf_fs_trace_destroy (the custom deleter wi... - 01:57 PM Babeltrace Revision 09721481 (babeltrace): src.ctf.fs: move struct ctf_fs_trace and struct ctf_fs_port_data up
- Move them so they are before ctf_fs_component. This enables the
following patches to use a unique_ptr to hold them i... - 01:57 PM Babeltrace Revision ef7d7ac2 (babeltrace): src.ctf.fs: use DataLen in ctf_fs_ds_index_entry
- Change-Id: I6ff4bdbad5358faa6f504b1ae52b6a4151fef27b
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision ca92fb37 (babeltrace): cpp-common/bt2c: add `DataLen` class (general-purpose data length)
- This patch adds the `bt2c::DataLen` class so that you can make sure your
function accepts an expected data length ins... - 01:57 PM Babeltrace Revision c942e7a2 (babeltrace): ctf: add ClkClsConfig and use it
- Different parts of the code in the ctf plugin (in fs-src, lttng-live and
common) use these three values:
- clock of... - 01:57 PM Babeltrace Revision f0940b01 (babeltrace): src.ctf.fs: remove uneeded check in create_streams_for_trace
- At this point, we certainly have a stream class.
The ir_sc field is set in ctf_stream_class_to_ir.
ctf_stream_class_... - 01:57 PM Babeltrace Revision 69d91bb3 (babeltrace): src.ctf.fs: query.cpp: change assertions into exceptions
- Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Change-Id: I21d5f8950ca8efa78713404a29c36442cba... - 01:57 PM Babeltrace Revision 0b9614ad (babeltrace): cpp-common: add `dataFromFile()`
- Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Change-Id: Ief289d7d12a1cc964af16dc7dd74a4422c8... - 01:57 PM Babeltrace Revision e44859b1 (babeltrace): src.ctf.fs: make ctf_fs_trace::trace a bt2::Trace::Shared
- Change-Id: I4fabe113da7b5adb794377706ab07fac9b59df02
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 1fa280c9 (babeltrace): ctf: use unique_ptr to manage ctf_metadata_decoder lifetime
- Introduce the ctf_metadata_decoder_up type, a unique_ptr with a deleter
that calls ctf_metadata_decoder_destroy. Cha... - 01:57 PM Babeltrace Revision 8d049eb2 (babeltrace): src.ctf.fs: manage lifetime of open file with FileUP
- Change-Id: Ic1c5d8be3761e449a154e1fd8cc1f0ec7c957197
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 9372bebb (babeltrace): src.ctf.fs: use GCharUP to hold metadata path
- Change-Id: I2cf43f7da567da3af2786a87026e25272925ed6f
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 49b956cc (babeltrace): src.ctf.fs: make ctf_fs_make_port_name return a GCharUP
- Make ctf_fs_make_port_name return a GCharUP, which then helps use
automatic memory management in the callers.
Change... - 01:57 PM Babeltrace Revision f340a3e8 (babeltrace): src.ctf.fs: use unique_ptr to manage ctf_fs_component lifetime
- Define ctf_fs_component::UP to be a unique_ptr with a deleter that calls
ctf_fs_destroy. Change ctf_fs_component_cre... - 01:57 PM Babeltrace Revision 708dab6b (babeltrace): ctf: use unique_ptr to manage ctf_visitor_generate_ir lifetime
- Define ctf_visitor_generate_ir::UP as a unique_ptr type with a custom
deleter that calls ctf_visitor_generate_ir_dest... - 01:57 PM Babeltrace Revision 0f80c86b (babeltrace): ctf: move ctf_visitor_generate_ir to header file
- Move ctf_visitor_generate_ir to the `ast.h` header file, the header file
containing all the declarations for the CTF ... - 01:57 PM Babeltrace Revision 1e690349 (babeltrace): ctf: add try/catch at entry points
- Add try / catch at the entry points of the CTF component classes to
convert thrown exceptions in the proper statuses.... - 01:57 PM Babeltrace Revision 35fbda93 (babeltrace): sink.text.details: don't write empty strings
- This patch makes a `sink.text.details` not write the value of a trace
environment entry or of a value object when it'... - 01:57 PM Babeltrace Revision c02af779 (babeltrace): src.ctf.fs: use C++ value wrappers in queries
- - Pass the query parameters as a bt2::ConstMapValue
- Return the query result as a bt2::Value::Shared
- Communicate... - 01:57 PM Babeltrace Revision 3c20ac12 (babeltrace): sink.ctf.fs: use bt2c::Logger
- Use `bt2c::Logger` throughout the `sink.ctf.fs` code.
When printing C strings that may be NULL (e.g. result of
`bt_t... - 01:57 PM Babeltrace Revision f0b83426 (babeltrace): cpp-common/bt2: make `FieldPathScope` a wise enum
- Change-Id: Ia07b63ff3afe01401ba633d0787ed726143abb05
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision b7bf92d2 (babeltrace): cpp-common/bt2: make `ValueType` a wise enum
- Change-Id: I0a0b060a094022844b159cedba87de566d4cfbac
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 150640e8 (babeltrace): sink.ctf.fs: initialize structure fields
- In preparation to using some C++ objects as fields. Allocate with new
and deallocate with delete where relevant.
Ch... - 01:57 PM Babeltrace Revision a1501ac9 (babeltrace): ctf: rename `ctx` structures
- Rename the various structures named `ctx` to something else, to avoid
ODR problems when C++-ifying them.
Change-Id: ... - 01:57 PM Babeltrace Revision 4e586d5e (babeltrace): cpp-common/bt2: make `UniqueConstError::_mError` a pointer
- Make this field a pointer instead of a reference, in order to make
`UniqueConstError` assignable. I don't really hav... - 01:57 PM Babeltrace Revision 0f5c5d5c (babeltrace): ctf: use `bt2c::Logger` throughout `src.ctf.fs`, `src.ctf.lttng-live`
- A lot of functions and structures have parameters or fields of type
`bt_self_component`, `bt_self_component_class` an... - 01:57 PM Babeltrace Revision 644c6ca7 (babeltrace): cpp-common/bt2c: make `Logger::Level` a wise enum
- Change-Id: I5298a6af1a6e5a8127d20f546746d5050d767f06
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 928d766d (babeltrace): cpp-common/bt2: make `MessageType` a wise enum
- Change-Id: I46182e774ae480b20461ce44add48cea47bb0f3a
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 91730cec (babeltrace): cpp-common/bt2c: add format_as() template functions for wise enums
- Add some format_as() functions in the bt2 and bt2c namespaces that will
apply to all wise enums defined in that names... - 01:57 PM Babeltrace Revision 8ae5c2b2 (babeltrace): cpp-common/vendor: add copy of wise_enum
- Add a copy of wise_enum, a smart enum library that allows doing cool
things like getting the number of enumerators of... - 01:57 PM Babeltrace Revision 33f20928 (babeltrace): cpp-common/bt2: move some enum classes out of enclosing classes
- Settle on the standard of having these enumerations out of the classes
that use them.
Change-Id: I241bdca560bf7f9e89... - 01:57 PM Babeltrace Revision 8f7f6134 (babeltrace): cpp-common/bt2c: use relative include for uuid.hpp in fmt.hpp
- Change-Id: Ic5b5dee8cd967ab8bc5ab476747e4b09e7aa1127
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 2f505dde (babeltrace): cpp-common/bt2c: add `BT_CPPLOGE_ERRNO_APPEND_CAUSE_SPEC`
- Add the `BT_CPPLOGE_ERRNO_APPEND_CAUSE_SPEC` macro, allowing to log an
error and append an error cause based on `errn... - 01:57 PM Babeltrace Revision aa37512c (babeltrace): cpp-common/bt2c: add `BT_CPPLOGE_APPEND_CAUSE_SPEC`
- Add the `BT_CPPLOGE_APPEND_CAUSE_SPEC` macro, allowing to log an error,
append a cause, but not throw.
Change-Id: I6... - 01:57 PM Babeltrace Revision 9d15c577 (babeltrace): cpp-common/bt2c: Logger: remove `noThrow` suffixes
- I think that the `noThrow` suffixes are unnecessary. Since the methods
that throw (or rethrow) have the `AndThrow` (... - 01:57 PM Babeltrace Revision 65b35e82 (babeltrace): cpp-common/bt2c: fix some function names in comments
- Change-Id: I1d66d431e36794daf3b35ab5b3600bcea3bc42d1
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 01:57 PM Babeltrace Revision 1c5ea5eb (babeltrace): Change naming convention for enum class enumerators
- Change the naming convention for enum class enumerators to not use
`ALL_CAPS`, as suggested by the C++ Core Guideline... - 01:57 PM Babeltrace Revision eee15e59 (babeltrace): Fix: cpp-common/bt2c: copy `_mSelfCompCls` when constructing `Logger`
- Change-Id: Ic7e8ddc09a4f943f845821e16323cf2d5c1a667c
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Reviewed... - 11:07 AM Babeltrace Revision d5689f24 (babeltrace): build: make out-of-tree builds with Python bindings work on msys2
- When doing an out of tree build on msys2 with
`--enable-python-bindings`, where the path to configure is absolute, I
...
04/15/2024
- 10:15 AM LTTng-tools Bug #1411 (Resolved): Memory leak when relay daemon exits before application starts
- 10:10 AM LTTng-modules Revision fb4b9097 (lttng-modules): Fix: timer_expire_entry changed in 4.19.312
- See upstream commit:
commit bbb5b1c060d73ca96ccc8cceaa81f5e1a96e8fa4
Author: Anna-Maria Gleixner <anna-maria...
04/12/2024
- 04:05 PM LTTng-UST Revision 9c3f3d02 (lttng-ust): docs: Add supported versions and fix-backport policy
- Change-Id: I9ec43912652fc713484959e9315765f7e9d29a3e
Signed-off-by: Kienan Stewart <kstewart@efficios.com>
Signed-off... - 04:04 PM LTTng-UST Revision 4ce89594 (lttng-ust): docs: Add cases in which tracepoints in ctors/dtors may not work
- Change-Id: I52666810322e26b3841ea1bca6f588b6c3e6f3f8
Signed-off-by: Kienan Stewart <kstewart@efficios.com>
Signed-off...
04/11/2024
- 04:09 PM LTTng-modules Revision 18fd6442 (lttng-modules): ring buffer: Use cpu_dcache_is_aliasing()
- Upstream Linux commit 8690bbcf3b7 ("Introduce cpu_dcache_is_aliasing()
across all architectures") allows checking whe... - 01:16 PM LTTng-UST Bug #1412 (Resolved): Trace decoding fails for trace generated on aarch64 with ctf_sequence using _length_type of uint32_t
- Marking as resolved on the LTTng-UST side.
This ends up being an issue with 0-length arrays/sequences alignment ha... - 12:42 PM LTTng-UST Bug #1412: Trace decoding fails for trace generated on aarch64 with ctf_sequence using _length_type of uint32_t
- babeltrace2 (2.0.5) indeed works fine. I'm of course not expecting a fix/release for babeltrace 1.5!
I can confirm... - 11:47 AM LTTng-UST Bug #1412: Trace decoding fails for trace generated on aarch64 with ctf_sequence using _length_type of uint32_t
- Which version of Trace Compass did you try it with ? Can you try with latest to see if there is still an issue ?
- 09:50 AM LTTng-UST Bug #1412: Trace decoding fails for trace generated on aarch64 with ctf_sequence using _length_type of uint32_t
- Patch fixing the issue for Babeltrace 1.5. It is EOL, so do not expect any release with this fix. Please use Babeltra...
- 09:31 AM LTTng-UST Bug #1412: Trace decoding fails for trace generated on aarch64 with ctf_sequence using _length_type of uint32_t
- I reproduced on x86-64 by applying this diff to lttng-ust.
- 09:21 AM LTTng-UST Bug #1412: Trace decoding fails for trace generated on aarch64 with ctf_sequence using _length_type of uint32_t
- Which version of Babeltrace do you use to reproduce ? Does it reproduce with Babeltrace 2 ?
I suspect an issue wit...
04/10/2024
- 06:13 PM LTTng-UST Bug #1412: Trace decoding fails for trace generated on aarch64 with ctf_sequence using _length_type of uint32_t
- Sorry, I re-read your comment and realized you were asking me to try using the latest version of lttng-tools too.
... - 05:42 PM LTTng-UST Bug #1412: Trace decoding fails for trace generated on aarch64 with ctf_sequence using _length_type of uint32_t
- I've attached the following traces:
# issue1412_mwe-20240410-211856_2-13-5.tar.xz: generated on the aarch64 system... - 04:21 PM LTTng-UST Bug #1412: Trace decoding fails for trace generated on aarch64 with ctf_sequence using _length_type of uint32_t
- Also can you reproduce with updated versions of lttng-ust and lttng-tools 2.13 ?
- 04:12 PM LTTng-UST Bug #1412: Trace decoding fails for trace generated on aarch64 with ctf_sequence using _length_type of uint32_t
- Please attach the resulting trace binary file and metadata to this ticket.
- 04:31 PM LTTng-tools Revision bc13dc0f (lttng-tools): docs: Add supported versions and fix-backport policy
- Change-Id: Idb22c6487e2397b807c5d1b78acbc2adb03be363
Signed-off-by: Kienan Stewart <kstewart@efficios.com>
Signed-off...
04/09/2024
- 04:38 PM LTTng-tools Revision 048f01ef (lttng-tools): docs: Partially document the liblttng-ctl C API
- This patch:
1. Performs the required changes to make the build system able to build
an HTML API documentation usi... - 01:18 PM LTTng-tools Revision 78f5b22d (lttng-tools): Fix: rotation-destroy-flush: fix session daemon abort if no kernel module present
- Testing rotation-destroy-flush when no lttng kernel modules present, it
would be failed with error message:
Error:...
04/05/2024
- 12:35 PM LTTng-UST Bug #1412 (Resolved): Trace decoding fails for trace generated on aarch64 with ctf_sequence using _length_type of uint32_t
- *Context:*
# Tracepoint with a `ctf_sequence` field using a `_length_type` of `uint32_t`
# No need to actually pa... - 12:13 PM LTTng-tools Revision 9fed015c (lttng-tools): Fix: consumerd: wrong timer mentioned in error logging
- As its name indicates, consumer_timer_monitor_stop() stops the _monitor_
timer; not the live timer. This is most like... - 12:12 PM LTTng-tools Revision fbd566c2 (lttng-tools): Fix: consumerd: type confusion in lttng_consumer_send_error
- lttng_consumer_send_error sends an lttcomm_return_code to the session
daemon. However, the size of lttcomm_sessiond_c...
04/03/2024
- 01:00 PM Babeltrace Revision 5ce6587e (babeltrace): src/Makefile.am: build {fmt} without `-Wmissing-noreturn`
- Until <https://github.com/fmtlib/fmt/pull/3917> is merged and becomes
part of a release, let's just ignore missing `[...
03/28/2024
- 01:52 PM Babeltrace Revision ca1b73a2 (babeltrace): Fix: cpp-common/bt2c/logging.hpp: remove one definition of `BT_CPPLOGE_APPEND_CAUSE_AND_THROW_SPEC`
- `BT_CPPLOGE_APPEND_CAUSE_AND_THROW_SPEC` has two identical definitions,
remove one.
Change-Id: Ia5b7caae53b65169081e... - 01:52 PM Babeltrace Revision 4f235e19 (babeltrace): Fix: cpp-common/bt2c/logging.hpp: don't set `_mSelfComp` when creating `Logger` for message iterator
- Only one context in `Logger` must be set. Similarly, when creating a
`Logger` for a component, we don't set `_mSelfC... - 01:52 PM Babeltrace Revision 2451f978 (babeltrace): compat: rename socket.h to socket.hpp
- `socket.h` is only included in C++ code, so make it a C++ file. This
makes it possible for an upcoming patch to make... - 01:52 PM Babeltrace Revision afb0f12b (babeltrace): ctf: allocate some structures with new
- Allocate some key structures in the ctf plugin with new (and free with
delete), so we can start using non-POD fields ... - 01:52 PM Babeltrace Revision a745c190 (babeltrace): ctf: remove unused `struct ctf_metadata_decoder`
- I noticed this struct was unused. There is another `struct
ctf_metadata_decoder` in src/plugins/ctf/decoder.cpp, tha... - 01:52 PM Babeltrace Revision 5656cea5 (babeltrace): src/plugins/ctf/common: restructure subtree
- This patch restructures the `src/plugins/ctf/common` subtree as such:
`src`:
Everything common to source compone... - 01:52 PM Babeltrace Revision 507d9140 (babeltrace): sink.text.pretty: abort on unknown field class type
- I don't think there a legimitate case for the print_field function to
encounter an invalid field class type. Change ... - 01:52 PM Babeltrace Revision 5934a96f (babeltrace): sink.ctf.fs: remove unused `fs_sink_ctf_field_class::index_in_parent` field
- This field is not used anywhere and looks like a leftover from a
previous iteration of the sink. Let's remove it.
Si... - 01:52 PM Babeltrace Revision b80bfc62 (babeltrace): configure.ac: build with `-DFMT_EXCEPTIONS=0`
- Coverity flags some functions marked `noexcept` that call `fmt::format`,
since `fmt::format` can throw `fmt::format_e...
03/27/2024
- 04:46 PM Babeltrace Revision 385ef9f1 (babeltrace): Fix: bt_value_map_borrow_entry_value(): use `@bt_pre_is_map_val`
- Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Change-Id: I48f15e9938d78245fd5f86a35935bf56fd304261 - 11:40 AM LTTng-tools Bug #1392: lttng view: Stream 0 is not declared in metadata
- Hi Kienan,
You are right, the VM has 8 CPUs, so with 8 subbuffers, it will exceed the available capacity. I lowere... - 09:27 AM LTTng-modules Revision 217bc2e4 (lttng-modules): Fix: dev_base_lock removed in linux 6.9-rc1
- See upstream commit:
commit 1b3ef46cb7f2618cc0b507393220a69810f6da12
Author: Eric Dumazet <edumazet@google.c... - 09:27 AM LTTng-modules Revision f4a6415f (lttng-modules): Fix: mm_compaction_migratepages changed in linux 6.9-rc1
- See upstream commit:
commit ab755bf4249b992fc2140d615ab0a686d50765b4
Author: Baolin Wang <baolin.wang@linux.... - 09:27 AM LTTng-modules Revision d8379ec6 (lttng-modules): Fix: ASoC add component to set_bias_level events in linux 6.9-rc1
- See upstream commit:
commit 6ef46a69ec32fe1cf56de67742fcd01af4bf48af
Author: Luca Ceresoli <luca.ceresoli@bo... - 09:25 AM LTTng-modules Revision fec007d9 (lttng-modules): Fix: ASoC snd_doc_dapm on linux 6.9-rc1
- See upstream commit:
commit 7df3eb4cdb6bbfa482f51548b9fd47c2723c68ba
Author: Luca Ceresoli <luca.ceresoli@bo...
Also available in: Atom